fix(browser): Propagate trace data from active span if http.client span is non-recording#22246
Open
Lms24 wants to merge 1 commit into
Open
fix(browser): Propagate trace data from active span if http.client span is non-recording#22246Lms24 wants to merge 1 commit into
http.client span is non-recording#22246Lms24 wants to merge 1 commit into
Conversation
…an is not recording
Contributor
size-limit report 📦
|
http.client span is not recording
http.client span is not recordinghttp.client span is non-recording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency with trace propagation via browser
http.clientspans: If anhttp.clientspan was started as aNonRecordingSpanwe'd still take it as the span we generate our tracing headers from (viagetTraceData). What we should do instead is to propagate the currently active span, so that span trees from a downstream service don't become orphaned.This PR also adds integration tests for 3 scenarios with
ignoreSpans:ref: #22262