feat(server-utils): Port S3, Kinesis, DynamoDB, SecretsManager and StepFunctions aws-sdk extensions#22164
Open
andreiborza wants to merge 9 commits into
Open
feat(server-utils): Port S3, Kinesis, DynamoDB, SecretsManager and StepFunctions aws-sdk extensions#22164andreiborza wants to merge 9 commits into
andreiborza wants to merge 9 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
3 times, most recently
from
c3ac3ce to
0e20b44
Compare
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
3 times, most recently
from
078c598 to
979ee5c
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
from
979ee5c to
e88a652
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
There are 11 total unresolved issues (including 7 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e88a652. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 8 total unresolved issues (including 7 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e88a652. Configure here.
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
4 times, most recently
from
07afc91 to
36d9255
Compare
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
from
52e07f6 to
69d0289
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
2 times, most recently
from
c61e735 to
7248300
Compare
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
2 times, most recently
from
69d0289 to
9510b15
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
from
7248300 to
50ce000
Compare
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
from
9510b15 to
61916ca
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
2 times, most recently
from
03eeceb to
fdd83ff
Compare
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
from
61916ca to
828e59f
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
from
fdd83ff to
735d2d1
Compare
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
from
88e502d to
cdb3108
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
from
735d2d1 to
36efbe1
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
from
36efbe1 to
ab30850
Compare
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
from
cdb3108 to
1f13ab5
Compare
andreiborza
requested review from
JPeer264,
chargome,
msonnb and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Reverts the makeSafeSpanBuilder extraction (and the graphql change that came with it) in favor of plain try/catch blocks at the three guard sites. The post-span hook and region provider keep their own guards so a throw there cannot discard the already-started span via the outer catch.
…epFunctions aws-sdk extensions Ports the attribute-only service extensions from the OTel aws-sdk integration to the orchestrion channel integration and registers them in the service registry: - S3: `aws.s3.bucket` - Kinesis: `aws.kinesis.stream.name` - DynamoDB: `db.*` and `aws.dynamodb.*` request/response attributes - SecretsManager: `aws.secretsmanager.secret.arn` (request and response) - StepFunctions: state machine / activity ARNs Straight ports; none of these inject trace propagation or change span lifecycle. Part of #20946 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/aws-sdk-server-utils
branch
from
1f13ab5 to
95b65dd
Compare
andreiborza
force-pushed
the
ab/aws-sdk-services
branch
from
e8972a4 to
f088bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the attribute-only service extensions from the OTel aws-sdk integration to the orchestrion channel integration and registers them in the service registry:
aws.s3.bucketaws.kinesis.stream.namedb.*andaws.dynamodb.*request/response attributesaws.secretsmanager.secret.arn(request and response)Straight ports; none of these inject trace propagation or change span lifecycle.
Part of #20946