Skip to content

fix(snapshots): Show clear error when project slug was renamed#3341

Merged
NicoHinderling merged 3 commits into
masterfrom
nico/fix/snapshots-project-rename-error
Jun 23, 2026
Merged

fix(snapshots): Show clear error when project slug was renamed#3341
NicoHinderling merged 3 commits into
masterfrom
nico/fix/snapshots-project-rename-error

Conversation

@NicoHinderling

@NicoHinderling NicoHinderling commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

snapshots upload against a renamed project slug failed with could not parse JSON response: missing field 'objectstore'. On a rename the API returns a 302 whose body the snapshot calls deserialized as their response type, bypassing convert_rnf — the helper every other project-scoped endpoint uses to surface renames.

This routes both snapshot calls through convert_rnf, which now reads the new slug from the top-level slug field the server actually sends (it previously read a non-existent detail.slug, leaving the rename message dead for all ProjectNotFound callers). Users now get the existing clear project was renamed to '<slug>' error.

Scope is project renames only; org renames (404) and the same latent failure on events list / issues commands are out of scope.

Fixes #3337

@NicoHinderling NicoHinderling marked this pull request as ready for review June 22, 2026 22:43
@NicoHinderling NicoHinderling requested review from a team and szokeasaurusrex as code owners June 22, 2026 22:43
@NicoHinderling NicoHinderling force-pushed the nico/fix/snapshots-project-rename-error branch from 233af6f to eda6057 Compare June 22, 2026 22:46
Comment thread src/api/mod.rs
@NicoHinderling NicoHinderling merged commit c96e571 into master Jun 23, 2026
29 checks passed
@NicoHinderling NicoHinderling deleted the nico/fix/snapshots-project-rename-error branch June 23, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snapshots fail to upload

2 participants