fix(trace-metrics): Replace nil trace IDs with a random one#6077
Closed
phacops wants to merge 1 commit into
Closed
fix(trace-metrics): Replace nil trace IDs with a random one#6077phacops wants to merge 1 commit into
phacops wants to merge 1 commit into
Conversation
phacops
force-pushed
the
fix/trace-metrics-nil-trace-id
branch
2 times, most recently
from
14b4753 to
d845494
Compare
An all-zero trace ID is invalid per the W3C trace context spec, but it parses successfully and was passed through to the stored trace item as-is. Generate a random trace ID during normalization instead, so these metrics no longer get grouped under a single bogus trace. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
phacops
force-pushed
the
fix/trace-metrics-nil-trace-id
branch
from
da90599 to
5799142
Compare
Member
|
Closing in favor of #6079. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trace metrics received with an all-zero (nil) trace ID now get a randomly generated trace ID during normalization. A nil trace ID is invalid per the W3C trace context spec, but it parses successfully into
TraceIdand was previously forwarded to the stored trace item as-is, grouping all such metrics under a single bogus trace.🤖 Generated with Claude Code