ref(auth): Make signature timestamp and its verification required#6069
Open
Dav1dde wants to merge 5 commits into
Open
ref(auth): Make signature timestamp and its verification required#6069Dav1dde wants to merge 5 commits into
Dav1dde wants to merge 5 commits into
Conversation
Dav1dde
force-pushed
the
dav1d/auth-sig-ts-required
branch
from
69f9fa2 to
87611ce
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Member
|
I'll let you handle the bot comments before I leave a review. |
Dav1dde
force-pushed
the
dav1d/auth-sig-ts-required
branch
from
7631e2d to
822d3b4
Compare
Dav1dde
force-pushed
the
dav1d/auth-sig-ts-required
branch
from
822d3b4 to
596890d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timestamp was effectively already required, except for where
SignedJsonwould not actually verify it (I'd say that's a bug).The timestamp was already unconditionally added in all code paths.
Removes a lot of API surface which is no longer required, only allows for a minimal API surface without allowing accidental mis-use.