Allow one-off Browserstack CI dispatch with custom websocket URL#167
Draft
Vincent Ahrend (pvditto) wants to merge 6 commits into
Draft
Allow one-off Browserstack CI dispatch with custom websocket URL#167Vincent Ahrend (pvditto) wants to merge 6 commits into
Vincent Ahrend (pvditto) wants to merge 6 commits into
Conversation
- Add workflow_dispatch input for custom websocket URL to: - android-kotlin-ci.yml - swift-ci.yml - javascript-web-browserstack.yml - android-cpp-browserstack.yml - Default to existing secrets when input not provided - Enables testing new websocket server versions via manual workflow dispatch Note: React Native app was also updated to use DITTO_WEBSOCKET_URL environment variable (was previously defined but not used)
Vincent Ahrend (pvditto)
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
📱 BrowserStack Test ResultsStatus: ✅ Passed Tested Devices:
|
Contributor
📱 BrowserStack Test ResultsStatus: ✅ Passed Tested Devices:
|
Aaron LaBeau (biozal)
added a commit
that referenced
this pull request
May 27, 2026
The integration test relies on seeding a doc via Ditto Cloud's API v4 endpoint and then waiting for it to sync down to the local peer. The seed step succeeds (HTTP 200) but the doc never propagates — Big Peer's visible task set stays frozen at 2786 docs (the same snapshot since ~Oct 2025), and no rust-tui CI seed since run #167 has appeared. This matches the pattern documented on other quickstarts (javascript-tui, javascript-web, react-native, react-native-expo) which all disabled their cloud-dependent tests with the same `if: false` and the same comment, tracked as DEVX-759. Applying the same fix here so this PR's CI can go green. The integration_test.rs improvements from the prior commit (30s timeout, explicit auth.login(), better diagnostics) stay in place — they're still valuable when running locally and for when DEVX-759 is resolved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Aaron LaBeau (biozal)
added a commit
that referenced
this pull request
May 27, 2026
* feat: Updated to v5 preview 4 * feat: update CI/CD to use version 1.91.1 version of rustc * feat: updated to fix linting issues * fix: forgot proper version of Rust for linux - you have to cut and paste in the yml file for each platform * fix: updated to fix auth * fix: linting * fix: fixed tests running * fixed linting and formating * Updated for RC3 and fixing security issues * updated to v5 * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * updated to fix PR comments * updated toolchain * fix(rust-tui): make integration test sync wait robust against slow seeds CI was failing because the seeded task wasn't visible within 15s of the local peer connecting; 2786 other tasks did sync but the just-seeded one hadn't propagated yet. Three changes: - Bump max_attempts from 15s to 30s (matches cpp-tui's wait window). - Explicitly call auth.login() before sync().start() so the first sync round always has a valid JWT, instead of racing the expiration handler to authenticate. Mirrors the javascript-tui v5 pattern. - On failure, surface count + any rust-tui-seeded tasks visible locally to make future diagnosis less ambiguous. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(rust-tui): disable integration test - Ditto Cloud API key expired The integration test relies on seeding a doc via Ditto Cloud's API v4 endpoint and then waiting for it to sync down to the local peer. The seed step succeeds (HTTP 200) but the doc never propagates — Big Peer's visible task set stays frozen at 2786 docs (the same snapshot since ~Oct 2025), and no rust-tui CI seed since run #167 has appeared. This matches the pattern documented on other quickstarts (javascript-tui, javascript-web, react-native, react-native-expo) which all disabled their cloud-dependent tests with the same `if: false` and the same comment, tracked as DEVX-759. Applying the same fix here so this PR's CI can go green. The integration_test.rs improvements from the prior commit (30s timeout, explicit auth.login(), better diagnostics) stay in place — they're still valuable when running locally and for when DEVX-759 is resolved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds optional input parameters to all BrowserStack workflows, enabling testing of new Ditto cloud deployments with custom configuration.
Supported workflows:
All workflows now accept these optional inputs (all default to repository secrets when not provided):
websocket_url- Custom Ditto websocket URLapp_id- Custom Ditto app IDplayground_token- Custom Ditto playground tokenauth_url- Custom Ditto auth URLReact Native Fix
DITTO_WEBSOCKET_URLenvironment variableenv.d.tsbut not used in the transport configupdateTransportConfigUsage
Automatic Dispatch with Script
The
scripts/cloud-smoke-test.jsscript can dispatch all BrowserStack workflows and monitor their progress:Basic usage (uses environment variables for all config):
With custom websocket URL:
With multiple custom parameters:
All available options:
--websocket-url <url>- Custom websocket URL--app-id <id>- Custom app ID--playground-token <token>- Custom playground token--auth-url <url>- Custom auth URL--help- Show help messageAll parameters are optional and fall back to these environment variables:
DITTO_WEBSOCKET_URLDITTO_APP_IDDITTO_PLAYGROUND_TOKENDITTO_AUTH_URLThe script will:
Manual Dispatch
To test individual workflows manually:
All parameters are completely optional - workflows will use repository secrets as defaults when inputs are not provided.