fix: export WrapperProps to fix TS2883 with declaration emit#760
Open
ThibautMarechal wants to merge 1 commit into
Open
fix: export WrapperProps to fix TS2883 with declaration emit#760ThibautMarechal wants to merge 1 commit into
ThibautMarechal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #759
What
Export
WrapperPropsfrom the mainformsy-reactentry point.Why
The return type of
withFormsy<T, V>is:When a project has
declaration: true(orcomposite: true) in tsconfig, TypeScript must write this type into the generated.d.tsfile. BecauseWrapperPropsis only reachable via the internaldist/withFormsypath and not the main entry, TypeScript raises TS2883 on every exported component:Exporting
WrapperPropsfrom the main entry gives TypeScript a portable name to reference, eliminating the error without any changes required in consumer code.Impact
WrapperPropsis already part of the implicit public API (it describes exactly what every consumer must pass to awithFormsy-wrapped component); making it explicit is an improvement.