ci: install flytectl directly instead of the broken setup action#3449
Closed
1fanwang wants to merge 1 commit into
Closed
ci: install flytectl directly instead of the broken setup action#34491fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
unionai-oss/flytectl-setup-action resolves the latest flytectl from the first page of flyteorg/flyte releases. That page is now entirely Flyte 2.0 (v2.0.x) tags with no flytectl/ release, so the action crashes with "Cannot read properties of undefined (reading 'assets')" and reds the integration jobs on master and every PR. Download the last flytectl release (v0.9.8) from its asset URL instead. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Contributor
Author
|
Folded into #3448 — the flytectl install fix and the plugin-deps fix have to ship on the same branch to go green (each PR was red only on the other's failure). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The
integrationjobs are red onmasterand on every PR. They fail at the Install FlyteCTL step:unionai-oss/flytectl-setup-action@masterresolves "latest" by listing the first page offlyteorg/flytereleases, filtering toflytectl/-prefixed tags, and readingi[0].assets. That page is now entirely Flyte 2.0 (v2.0.x) release tags — noflytectl/release appears on it — so the filtered list is empty andi[0].assetsthrows. (Thectl.flyte.orginstall script has the same first-page limitation, so it isn't a workaround either.)What changes were proposed in this pull request?
Install flytectl by downloading the last published release,
flytectl/v0.9.8, directly from its asset URL — no release-list resolution involved.v0.9.8is the same version the action installed back when it worked.Unblocks the red
integrationchecks across all open PRs.How was this patch tested?
CI on this PR is the real check — the
integrationjobs now get past the FlyteCTL install and intoflytectl demo start. Out of band I confirmed the asset URL resolves and the tarball holds theflytectlbinary at its root. I can't run GitHub Actions locally, so I'm relying on this PR's run for the green.Check all the applicable boxes