[auto_submit] Improve enqueue failure message to hint at missing CI labels#5019
Closed
DaveT1991 wants to merge 1 commit into
Closed
[auto_submit] Improve enqueue failure message to hint at missing CI labels#5019DaveT1991 wants to merge 1 commit into
DaveT1991 wants to merge 1 commit into
Conversation
When enqueueing a PR fails (e.g. HTTP 400 from the merge queue), the error message now includes actionable guidance to check that CI labels have been added before using the autosubmit label. Fixes flutter/flutter#184848
Member
|
Thank you for this Pr, but I don't think we want to land this. Cocoon and Auto-submit are internal only infra and we do not expect to receive external contributors to it. The issue you linked is already closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PR is added to the merge queue but required CI checks have not been triggered (e.g. missing CI labels), the enqueue call fails with an opaque HTTP 400 error that gives no actionable guidance. The error previously read:
auto label is removed for flutter/flutter/183971, Failed to enqueue flutter/flutter/183971 with HTTP 400: GraphQL mutate failed.
This PR appends a hint to that message telling the author to verify CI labels have been added before using the autosubmit label.
Fixes flutter/flutter#184848
Pre-launch Checklist
I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read the [Flutter Style Guide] recently, and have followed its advice.
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.