Fix event loop re-entrancy issue on merged thread policy#171
Merged
seungsoo47 merged 3 commits intoMay 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies TizenPlatformEventLoop::OnTaskExpired to move expired_tasks_ into a local vector under a mutex lock before executing the tasks. A review comment suggests explicitly clearing expired_tasks_ after the move to avoid leaving it in an unspecified state, which could trigger static analysis warnings or lead to undefined behavior when reused.
JSUYA
reviewed
May 27, 2026
JSUYA
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an event loop re-entrancy issue under the merged UI/Platform thread policy by using a local variable to prevent memory corruption and task dispatch failures.