This PR is to add comments to GetTieredStoreInfo in pkg\ddc\base\runtime.go.#5912
This PR is to add comments to GetTieredStoreInfo in pkg\ddc\base\runtime.go.#5912JerryMLJ wants to merge 2 commits into
Conversation
Signed-off-by: JerryMLJ <13721512405@163.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @JerryMLJ. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Code Review
This pull request adds documentation comments to the GetTieredStoreInfo method in pkg/ddc/base/runtime.go. The reviewer identified that the added comments are overly verbose, redundant with documentation in other parts of the code, and contain a technical inaccuracy regarding the state of the Levels slice when no levels are defined. A more concise and accurate comment was suggested to improve clarity and adhere to Go documentation conventions.
Signed-off-by: JerryMLJ <13721512405@163.com>
|
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5912 +/- ##
=======================================
Coverage 62.59% 62.59%
=======================================
Files 480 480
Lines 32801 32801
=======================================
Hits 20533 20533
Misses 10633 10633
Partials 1635 1635 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
|
|
|
|
The |



Ⅰ. Describe what this PR does
Add comments to GetTieredStoreInfo in pkg\ddc\base\runtime.go.
Ⅱ. Does this pull request fix one issue?
fixes #5914
III. Special notes for reviews