Skip to content

This PR is to add comments to GetTieredStoreInfo in pkg\ddc\base\runtime.go.#5912

Open
JerryMLJ wants to merge 2 commits into
fluid-cloudnative:masterfrom
JerryMLJ:new-branch
Open

This PR is to add comments to GetTieredStoreInfo in pkg\ddc\base\runtime.go.#5912
JerryMLJ wants to merge 2 commits into
fluid-cloudnative:masterfrom
JerryMLJ:new-branch

Conversation

@JerryMLJ
Copy link
Copy Markdown

@JerryMLJ JerryMLJ commented May 25, 2026

Ⅰ. Describe what this PR does

Add comments to GetTieredStoreInfo in pkg\ddc\base\runtime.go.

Ⅱ. Does this pull request fix one issue?

fixes #5914

III. Special notes for reviews

Signed-off-by: JerryMLJ <13721512405@163.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheyang for approval by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 25, 2026

Hi @JerryMLJ. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation comments to the GetTieredStoreInfo method in pkg/ddc/base/runtime.go. The reviewer identified that the added comments are overly verbose, redundant with documentation in other parts of the code, and contain a technical inaccuracy regarding the state of the Levels slice when no levels are defined. A more concise and accurate comment was suggested to improve clarity and adhere to Go documentation conventions.

Comment thread pkg/ddc/base/runtime.go Outdated
Signed-off-by: JerryMLJ <13721512405@163.com>
@sonarqubecloud
Copy link
Copy Markdown

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 26, 2026

/ok-to-test

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.59%. Comparing base (9e74e92) to head (83f58c8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5912   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files         480      480           
  Lines       32801    32801           
=======================================
  Hits        20533    20533           
  Misses      10633    10633           
  Partials     1635     1635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 27, 2026

⚠️ lint check 失败 — 此 comment-only PR 的 lint 检查未通过。comment-only 改动不应引入 lint 错误,请检查是否是格式问题并修复后重新推送。

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 28, 2026

⚠️ Non-e2e check failed: lint check has failed. This is a comment-only PR and lint failure needs to be resolved before review can proceed. Please check the lint output and fix any issues.

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 28, 2026

⚠️ lint check 失败 — 此 PR 的 lint 检查未通过(非 e2e 类失败)。请检查 lint 输出并修复后重新提交。

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 29, 2026

The lint check is failing on this PR. Since this is a comment-only change, the lint failure is likely unrelated to your diff. Please check the lint output and fix if needed, or rebase on the latest master to see if the failure resolves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to GetTieredStoreInfo in pkg\ddc\base\runtime.go.

2 participants