Skip to content

Ensure that the options and copy for both Add hosts - Android and iOS/iPadOS are the same#49227

Merged
Leanngove merged 2 commits into
mainfrom
leann-hosts-popup
Jul 14, 2026
Merged

Ensure that the options and copy for both Add hosts - Android and iOS/iPadOS are the same#49227
Leanngove merged 2 commits into
mainfrom
leann-hosts-popup

Conversation

@Leanngove

@Leanngove Leanngove commented Jul 13, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #42721

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • New Features
    • Updated iOS/iPadOS enrollment labeling to clarify the fully managed company-owned option.
    • Added enrollment guidance explaining that users must download the profile in their browser and install it to enroll in Fleet.
  • Tests
    • Expanded coverage to verify the updated enrollment option and instructions on iOS/iPadOS and Android.

@Leanngove Leanngove requested a review from a team as a code owner July 13, 2026 17:57
@Leanngove Leanngove changed the title Ensure that the options and copy for both Add host - Android and iOS/iPadOS are the same Ensure that the options and copy for both Add hosts - Android and iOS/iPadOS are the same Jul 13, 2026
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Android enrollment URLs now include guidance that the enrollment profile downloads in the end user’s browser and must be installed. The iOS/iPadOS company-owned option is labeled “Company-owned (fully-managed).” Add Hosts modal tests now verify the updated labels and enrollment instructions for iOS/iPadOS and Android.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR adds Android enrollment instructions, but it does not address the issue's Android option/tooltips and Work Profile capitalization requirements. Update the Android enrollment options to clarify Work profile/Fully-managed terminology, add the requested tooltips, and capitalize Work Profile consistently.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: aligning Android and iOS/iPadOS Add Hosts copy and options.
Description check ✅ Passed The description includes the related issue and testing notes, which is sufficient for this small UI-focused change.
Out of Scope Changes check ✅ Passed The changes stay within Add Hosts Android/iOS-iPadOS copy and test updates, with no unrelated scope introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch leann-hosts-popup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@frontend/components/AddHostsModal/PlatformWrapper/AndroidPanel/AndroidPanel.tsx`:
- Around line 42-45: Update the helpText in AndroidPanel to explicitly instruct
admins to send the enrollment URL to the end user, while preserving the download
and installation guidance. Correct the wording from “enroll to Fleet” to “enroll
in Fleet.”
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1025e7dd-a76b-490b-be62-196b98660d67

📥 Commits

Reviewing files that changed from the base of the PR and between 74b10d8 and 921e7a4.

📒 Files selected for processing (3)
  • frontend/components/AddHostsModal/AddHostsModal.tests.tsx
  • frontend/components/AddHostsModal/PlatformWrapper/AndroidPanel/AndroidPanel.tsx
  • frontend/components/AddHostsModal/PlatformWrapper/IosIpadosPanel/IosIpadosPanel.tsx

Comment on lines +42 to +45
const helpText =
"When the end user navigates to this URL, the enrollment profile " +
"will download in their browser. End users will have to install the profile " +
"to enroll to Fleet.";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Tell admins to send the enrollment URL.

At Line 42-45, the copy only explains what happens after navigation; it does not instruct admins to send the URL to the end user, which is an explicit PR requirement. Also change “enroll to Fleet” to “enroll in Fleet.”

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@frontend/components/AddHostsModal/PlatformWrapper/AndroidPanel/AndroidPanel.tsx`
around lines 42 - 45, Update the helpText in AndroidPanel to explicitly instruct
admins to send the enrollment URL to the end user, while preserving the download
and installation guidance. Correct the wording from “enroll to Fleet” to “enroll
in Fleet.”

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product sets copy. This shouldn't be a point of feedback in automated PR reviews.

@Leanngove Leanngove merged commit 1be50fd into main Jul 14, 2026
15 checks passed
@Leanngove Leanngove deleted the leann-hosts-popup branch July 14, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hosts popup for Android should include the same instructions as iOS & iPadOS and clarify "Work profile"

2 participants