Ensure that the options and copy for both Add hosts - Android and iOS/iPadOS are the same#49227
Conversation
…the same for the Add hosts modal.
WalkthroughAndroid enrollment URLs now include guidance that the enrollment profile downloads in the end user’s browser and must be installed. The iOS/iPadOS company-owned option is labeled “Company-owned (fully-managed).” Add Hosts modal tests now verify the updated labels and enrollment instructions for iOS/iPadOS and Android. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@frontend/components/AddHostsModal/PlatformWrapper/AndroidPanel/AndroidPanel.tsx`:
- Around line 42-45: Update the helpText in AndroidPanel to explicitly instruct
admins to send the enrollment URL to the end user, while preserving the download
and installation guidance. Correct the wording from “enroll to Fleet” to “enroll
in Fleet.”
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1025e7dd-a76b-490b-be62-196b98660d67
📒 Files selected for processing (3)
frontend/components/AddHostsModal/AddHostsModal.tests.tsxfrontend/components/AddHostsModal/PlatformWrapper/AndroidPanel/AndroidPanel.tsxfrontend/components/AddHostsModal/PlatformWrapper/IosIpadosPanel/IosIpadosPanel.tsx
| const helpText = | ||
| "When the end user navigates to this URL, the enrollment profile " + | ||
| "will download in their browser. End users will have to install the profile " + | ||
| "to enroll to Fleet."; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Tell admins to send the enrollment URL.
At Line 42-45, the copy only explains what happens after navigation; it does not instruct admins to send the URL to the end user, which is an explicit PR requirement. Also change “enroll to Fleet” to “enroll in Fleet.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@frontend/components/AddHostsModal/PlatformWrapper/AndroidPanel/AndroidPanel.tsx`
around lines 42 - 45, Update the helpText in AndroidPanel to explicitly instruct
admins to send the enrollment URL to the end user, while preserving the download
and installation guidance. Correct the wording from “enroll to Fleet” to “enroll
in Fleet.”
There was a problem hiding this comment.
Product sets copy. This shouldn't be a point of feedback in automated PR reviews.
Related issue: Resolves #42721
Testing
Summary by CodeRabbit