Drop old Ignition OEM mounting code and bump bootengine with new mount handling#3934
Merged
Drop old Ignition OEM mounting code and bump bootengine with new mount handling#3934
Conversation
chewi
force-pushed
the
chewi/ignition-mounting
branch
from
ff3cd14 to
807a1e2
Compare
krnowak
approved these changes
Apr 15, 2026
Member
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
Thanks. Just please remember to update the commit hashes in the ebuilds.
bootengine will mount the partition before Ignition starts instead. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
force-pushed
the
chewi/ignition-mounting
branch
from
807a1e2 to
32f35c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a long time, we have been patching code back into Ignition to handle mounting the OEM partition. This drops most of that, leaving just the part needed to handle the
oem://scheme, which now assumes that the OEM partition is already mounted by bootengine.The hope is to eventually drop even more patches from Ignition and use a new
file://scheme with Butane doing the mapping fromoem://tofile:///oem.See flatcar/bootengine#121 for the associated bootengine changes and flatcar/init#143 for the associated init changes.
How to use
See flatcar/bootengine#121 as most of the changes are there.
Testing done
Jenkins has passed with these changes alongside the associated bootengine changes. I have also done lots of manual testing.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.