Conversation
Examples migrated to the standalone fjc/examples repo. Remove the
orphaned deploy workflows, the still-tracked mobile fishjam-chat app,
and the stale readme link; regenerate yarn.lock.
- rm .github/workflows/{fishjam-chat,livestreaming-example,mobile_eas_build}.yaml
- rm examples/mobile-client/fishjam-chat
- drop Fishjam Chat bullet from packages/react-client/readme.md
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy example-app deployment workflows and deletes the now-orphaned React Native “fishjam-chat” example from the monorepo, with a small documentation update in the React client README.
Changes:
- Removed GitHub Actions workflows for Fishjam Chat deployment, livestreaming example deployment, and mobile EAS builds.
- Deleted the
examples/mobile-client/fishjam-chatReact Native app (source, configs, and docs). - Updated
packages/react-client/readme.mdto drop the Fishjam Chat example reference.
Reviewed changes
Copilot reviewed 36 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react-client/readme.md | Removes Fishjam Chat example link from React client docs. |
| examples/mobile-client/fishjam-chat/utils/fishjamIdStore.ts | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/utils/Colors.ts | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/tsconfig.json | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/README.md | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/prettier.config.js | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/package.json | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/index.js | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/hooks/useMediaPermissions.ts | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/eas.json | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/VideosGrid.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/Typo.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/TextInput.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/NoCameraView.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/index.ts | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/InCallButton.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/DismissKeyboard.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/components/Button.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/babel.config.js | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/room/preview.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/room/[roomName].tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/livestream/viewer.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/livestream/streamer.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/livestream/screen-sharing.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/index.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/(tabs)/room.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/(tabs)/livestream.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/(tabs)/_layout.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app/_layout.tsx | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/app.json | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/.gitignore | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/.eslintrc.js | Deleted as part of removing the fishjam-chat mobile example. |
| examples/mobile-client/fishjam-chat/.env.example | Deleted as part of removing the fishjam-chat mobile example. |
| .github/workflows/mobile_eas_build.yaml | Removes workflow that built/submitted the mobile fishjam-chat app with EAS. |
| .github/workflows/livestreaming-example.yaml | Removes GitHub Pages deploy workflow for the livestreaming example. |
| .github/workflows/fishjam-chat.yaml | Removes Fishjam Chat deployment workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address Copilot review: drop the non-existent broadcast link and the stale examples-index anchor, fix grammar. Only minimal-react remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples migrated to the standalone fjc/examples repo. Remove the orphaned deploy workflows, the still-tracked mobile fishjam-chat app, and the stale readme link; regenerate yarn.lock.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)