Update isLocalURL to include LAN addresses, .local domains, and hostn…#5973
Open
cathaysia wants to merge 4 commits into
Open
Update isLocalURL to include LAN addresses, .local domains, and hostn…#5973cathaysia wants to merge 4 commits into
cathaysia wants to merge 4 commits into
Conversation
cathaysia
force-pushed
the
main
branch
2 times, most recently
from
38f05a1 to
c5cad4d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5973 +/- ##
==========================================
+ Coverage 85.34% 85.35% +0.01%
==========================================
Files 318 318
Lines 31922 31947 +25
Branches 8834 8851 +17
==========================================
+ Hits 27244 27269 +25
Misses 4246 4246
Partials 432 432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
reviewed
Apr 30, 2026
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks for the PR, adding some comments below.
cathaysia
force-pushed
the
main
branch
2 times, most recently
from
7dcfd1c to
ee13e17
Compare
Author
|
before: 
after: 
|
Author
|
can this pr be merged? |
Contributor
|
Hey @cathaysia, you need to re-request review when you've done working on the feedback. I'll do that for you now :) |
Author
|
thanks |
canova
requested changes
May 27, 2026
Comment on lines
+24
to
+30
| /^127\./.test(hostname) || // Loopback 127.0.0.0/8 | ||
| /^10\./.test(hostname) || // Private 10.0.0.0/8 | ||
| /^172\.(1[6-9]|2[0-9]|3[0-1])\./.test(hostname) || // Private 172.16.0.0/12 | ||
| /^192\.168\./.test(hostname) || // Private 192.168.0.0/16 | ||
| /^100\.(6[4-9]|[7-9][0-9]|1[0-1][0-9]|12[0-7])\./.test(hostname) || // CGNAT 100.64.0.0/10 | ||
| /^169\.254\./.test(hostname) || // Link-local 169.254.0.0/16 | ||
| /^198\.(1[8-9])\./.test(hostname) // Benchmark 198.18.0.0/15 |
Member
There was a problem hiding this comment.
These match hostnames like:
192.168.1.1.foo.com
URL.hostname will happily return these host names. Please make sure that the host names are actually ipv4 addresses.
Author
There was a problem hiding this comment.
I updated the regex, could you please check it again?
cathaysia
force-pushed
the
main
branch
2 times, most recently
from
a76c6c5 to
1ae49e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat non-public addresses—such as loopback addresses, LAN addresses, and CGNAT addresses—as local addresses; this allows for direct access to computers within the local network, Tailscale and etc..