fix: make jcpan -t Inline pass#746
Closed
fglock wants to merge 1 commit into
Closed
Conversation
- Treat jar:PERL5LIB paths as stable absolutes in Internals::abs_path so
Inline::derive_minus_I never emits bare -I flags.
- Implement perlrun-style alternate shebang delegation for wrappers such as
inc/bin/testml-cpan (word-boundary perl/indir detection, skip self-exec,
spawn via PERLONJAVA_EXECUTABLE when the wrapper targets jperl).
- Preserve argv spelling when delegating so TestML path rewrites stay relative.
- In diagnostics.pm death_trap, detect eval context from "(eval N) line"
when caller lacks an (eval) frame under $SIG{__DIE__}.
Verified: make; ./jcpan -t Inline
Generated with [Cursor](https://cursor.com/docs)
Co-Authored-By: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
./jcpan -t Inline, which was failing on Inline’s TestML-driven.tfiles, bogus-Iflags from@INCentries underjar:PERL5LIB, anddiagnostics.pmtreating eval-bound exceptions as uncaught inside$SIG{__DIE__}.Changes
Internals::abs_pathreturns existingjar:…library paths unchanged instead of undef (matches-e/ Inline’sderive_minus_Iexpectations).ArgumentParsershebang handling aligns with perlrun: alternate interpreters when#!has no wordperl/indir; avoid infinite self-exec forjperl; delegate wrappers such asinc/bin/testml-cpanviaPERLONJAVA_EXECUTABLEwhen their own shebang points at jperl; keep the original argv spelling (t/foo.t) so TestML path rewriting works.diagnostics.pmdetects eval context from(eval N) linein the exception text whencaller()does not expose an(eval)frame during$SIG{__DIE__}.Test plan
make(full unit test shard suite)timeout 600 ./jcpan -t Inline→ PASS (33 tests)