fix: unit tests pass with standard Perl (prove)#744
Merged
Conversation
…andling Failures from can() returned an empty list, corrupting Mite __META__ hash literals and breaking Sub::HandlesVia constructor dispatch. Returned values now use singleton undef matching Perl list semantics. Add RuntimeScalar(String, int stringType) and route concatenation helpers through explicit STRING vs BYTE_STRING selection. Document Sub::HandlesVia next steps under dev/modules/. Generated with Cursor (https://cursor.com/docs) Co-Authored-By: Cursor <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
StringOperators stringConcat* and RuntimeScalar(String,int) regressed perl5_t smoke (op/sub.t, porting/filenames.t, re/pat_advanced.t). Restore the prior concat implementation; retain scalarUndef.getList() on failed can() for Mite. Update design + dev/modules docs with the revert and a safer redo checklist. Generated with Cursor (https://cursor.com/docs) Co-Authored-By: Cursor <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Skip or guard optional deps (DBD::SQLite, Internals, Moose stack), fix open.pm loading without the open() builtin parse conflict, relax strict subs for intentional bareword concatenation, teach the Storable regression about inline packages (INC + thaw hook), and skip SO_ACCEPTCONN checks when getsockopt returns nothing (e.g. macOS). Generated with [Cursor](https://cursor.com/docs) Co-Authored-By: Cursor <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
RuntimeHash/RuntimeArray referents at refCount==-1 could skip refcount bookkeeping via the setLargeRefCounted untracked fast path; align with incrementRefCountForContainerStore (push / anon hash finalize). docs(modules): ppi.md Phase 1b status and future perlObjectId/refaddr note Generated with [Cursor](https://cursor.com/docs) Co-Authored-By: Cursor <cursoragent@cursor.com>
Unify both lines of work for combined testing before merge to master.
Emit \ on string literals with getScalarByteString/getScalarString so the RuntimeScalar identity matches JavaClassInfo padConstants. Moo accessor-weaken.t expects weak refs to readonly consts to clear when the CV is replaced (optree reaping); materialize* copies broke clearPadConstantWeakRefs. Generated with [Cursor](https://cursor.com/docs) Co-Authored-By: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DBD::SQLite,Internals, Moose /namespace::autoclean) withskip_allwhen modules are missing soprove src/test/resources/unitcompletes successfully on typical developer Perl installs.open_pragma.tto loadopen.pmviarequire 'open.pm'so theopenbuiltin does not swallow the directive.leading_colon_bareword_call.twithno strict 'subs'so the intended stringification behavior is exercised without a compile error under strictures.pr709_core_regressions.tStorable case: fake%INCfor the inline package and addSTORABLE_thawsodclonematches current Storable behavior.SO_ACCEPTCONNassertions insocket_options.twhengetsockoptreturnsundef(e.g. macOS).Test plan
prove src/test/resources/unit(system Perl)makeMade with Cursor