chore(deps): bump vite-plus to pkg-pr-new PR #1703#7
Draft
fengmk2 wants to merge 3 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several package dependencies to use pre-release pkg.pr.new URLs and moves PNPM configuration options from the root package.json to pnpm-workspace.yaml. However, PNPM configuration settings like onlyBuiltDependencies, overrides, and security policies are not supported in pnpm-workspace.yaml and will be ignored by PNPM. They must be restored to the root package.json to prevent build failures and broken dependency overrides.
Comment on lines
+120
to
+155
| onlyBuiltDependencies: | ||
| - esbuild | ||
|
|
||
| overrides: | ||
| "@azure/msal-node>uuid": 11.1.1 | ||
| "@unhead/vue": 2.1.15 | ||
| defu: 6.1.7 | ||
| devalue: 5.8.1 | ||
| dompurify: 3.4.4 | ||
| h3: 1.15.11 | ||
| nanotar: 0.3.0 | ||
| nitropack: 2.13.4 | ||
| node-forge: 1.4.0 | ||
| nuxt: 4.4.6 | ||
| qs: 6.15.2 | ||
| simple-git: 3.36.0 | ||
| srvx: 0.11.15 | ||
| svgo: 4.0.1 | ||
| tar: 7.5.15 | ||
| yaml: 2.9.0 | ||
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8" | ||
| "@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8" | ||
| "@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@d0b407c85b560c2470395176c9f1c838b5ca8af8" | ||
|
|
||
| blockExoticSubdeps: false | ||
| minimumReleaseAge: 60 | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/vite-plus-core" | ||
| - "@voidzero-dev/vite-plus-test" | ||
| - "@voidzero-dev/vite-plus-prompts" | ||
| - "@oxc-project/*" | ||
| - "@oxlint/*" | ||
| - oxlint | ||
| - oxfmt | ||
| - oxlint-tsgolint |
There was a problem hiding this comment.
PNPM configuration options such as onlyBuiltDependencies, overrides, blockExoticSubdeps, minimumReleaseAge, and minimumReleaseAgeExclude are not supported at the root level of pnpm-workspace.yaml. They must be defined in the root package.json under the pnpm property. Placing them here will cause PNPM to ignore them, which will break the dependency overrides and the build (since esbuild won't be allowed to run its build script).
Comment on lines
+23
to
24
| "packageManager": "pnpm@10.0.0" | ||
| } |
There was a problem hiding this comment.
Restore the pnpm configuration block in the root package.json containing onlyBuiltDependencies, overrides, and other security settings. These options are ignored when placed in pnpm-workspace.yaml.
"packageManager": "pnpm@10.0.0",
"pnpm": {
"onlyBuiltDependencies": [
"esbuild"
],
"overrides": {
"@azure/msal-node>uuid": "11.1.1",
"@unhead/vue": "2.1.15",
"defu": "6.1.7",
"devalue": "5.8.1",
"dompurify": "3.4.4",
"h3": "1.15.11",
"nanotar": "0.3.0",
"nitropack": "2.13.4",
"node-forge": "1.4.0",
"nuxt": "4.4.6",
"qs": "6.15.2",
"simple-git": "3.36.0",
"srvx": "0.11.15",
"svgo": "4.0.1",
"tar": "7.5.15",
"yaml": "2.9.0",
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8",
"@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@d0b407c85b560c2470395176c9f1c838b5ca8af8"
},
"blockExoticSubdeps": false,
"minimumReleaseAge": 60,
"minimumReleaseAgeExclude": [
"vite-plus",
"@voidzero-dev/vite-plus-core",
"@voidzero-dev/vite-plus-test",
"@voidzero-dev/vite-plus-prompts",
"@oxc-project/*",
"@oxlint/*",
"oxlint",
"oxfmt",
"oxlint-tsgolint"
]
}
}
@vizejs/fresco
@vizejs/musea-mcp-server
@vizejs/musea-nuxt
@vizejs/nuxt
oxlint-plugin-vize
@vizejs/rspack-plugin
@vizejs/unplugin
@vizejs/vite-plugin-musea
@vizejs/vite-plugin
vize
commit: |
fengmk2
changed the title
Detailed Test ReportCommit: Area Summary
Test InventoryTotal tracked cases: 4724 across 632 files.
Files
Full per-test names are written to the workflow summary and uploaded as an artifact. Job Overview
Step DetailsOther / cargo-semver-checks: cancelled, 4m 50s
Other / node-engine-compat (22): cancelled, 4m 50s
Other / node-engine-compat (24): failure, 25s
Other / test-report-comment: in_progress, -
|
PR BenchmarkBase:
Raw run timesCompile SFC
Lint
Type check
|
Detailed Test ReportCommit: Area Summary
Test InventoryTotal tracked cases: 4724 across 632 files.
Files
Full per-test names are written to the workflow summary and uploaded as an artifact. Job Overview
Step DetailsRust / coverage: success, 1m 3s
Other / cargo-semver-checks: cancelled, 8m 10s
Other / node-engine-compat (22): cancelled, 8m 10s
Other / node-engine-compat (24): success, 59s
Other / check-vize-apps: success, 1m 22s
Other / test-report-comment: in_progress, -
|
Detailed Test ReportCommit: Area Summary
Test InventoryTotal tracked cases: 4724 across 632 files.
Files
Full per-test names are written to the workflow summary and uploaded as an artifact. Job Overview
Step DetailsJS / TS / check-js: failure, 22s
Rust / clippy-and-test: success, 3m 58s
Rust / fmt-rust: success, 19s
Rust / coverage: success, 1m 8s
Other / test-scripts: failure, 52s
Other / test-js-packages: failure, 59s
Other / cargo-semver-checks: failure, 8m 55s
Other / vue-parity: failure, 41s
Other / check-vize-apps: failure, 51s
Other / node-engine-compat (24): failure, 21s
Other / node-engine-compat (22): failure, 21s
Other / build-js-packages: failure, 59s
Comment truncated at 64000 characters. Open the workflow run for the full job log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
vite-plusand related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).Test plan