[Meta] Add GitHub workflow for run_scripts pytest unit tests#1237
Open
AarjunC wants to merge 3 commits into
Open
[Meta] Add GitHub workflow for run_scripts pytest unit tests#1237AarjunC wants to merge 3 commits into
AarjunC wants to merge 3 commits into
Conversation
Summary: Add per-subclass tests pinning binary names, conditional flag construction, filter behavior, and warmboot-script dispatch. - test_sai_agent_runner.py (10): mono vs multi_switch branching for warmboot file, replayer flags, run-args; production-feature filtering in `_filter_tests`; warmboot-script dispatch via `_setup_warmboot_test`. - test_link_runner.py (5): mono vs multi binary, warmboot file by mode, service start order (FSDB -> QSFP -> HW Agent), --disable-fsdb skip. - test_platform_services_runner.py (8): parametrized type -> binary map with fallback; multi-type iteration when --type omitted. - test_bcm_runner.py (3, NEW): default constants; `_get_sai_logging_flags` no-arg signature. - test_sai_runner.py (6, NEW): 5-flag SAI replayer set construction; optional --platform_mapping_override_path append; known-bad-tests file override fallback to SAI_HW_KNOWN_BAD_TESTS. - test_qsfp_runner.py (5, NEW): conditional --platform_mapping_override_path and --bsp_platform_mapping_override_path appends; coldboot wipes QSFP_SERVICE_DIR via subprocess.Popen. Differential Revision: D106428878
Summary: Add lifecycle tests for the systemd service helpers wrapped by run_test.py runners. These pin the contract before the planned modular refactor moves these files into a `services/` subpackage. - test_agent_service.py (7): warmboot file path helper; cleanup stops the prod / for_testing / oss service variants and pkills each; setup raises on missing binary or missing config; setup_and_start dispatches warm vs cold; warm-boot file-missing behavior pinned for `warm_boot_hw_agent`. - test_fsdb_service.py (4): cleanup teardown, setup preconditions, cold-boot creates marker / warm-boot skips, start orchestration. - test_qsfp_service.py (5): cleanup teardown, setup preconditions, FSDB disabled vs enabled flips --fsdb_client_ssl_preferred=false in the unit file, --platform_mapping_override_path appended into ExecStart when set, cold/warm marker behavior. Differential Revision: D106437058
Summary: Adds a lightweight GHA workflow that runs the pytest unit tests under `fboss/oss/scripts/run_scripts/tests/` on PRs that touch `run_scripts/**`. The existing `docker-unittest.py` only discovers compiled gtest binaries, so these ~120 pure-Python tests currently run on no PR. Runs in seconds with no getdeps/docker. Differential Revision: D106542800
Contributor
|
@AarjunC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106542800. |
AarjunC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Adds a lightweight GHA workflow that runs the pytest unit tests under
fboss/oss/scripts/run_scripts/tests/on PRs that touchrun_scripts/**. The existingdocker-unittest.pyonly discovers compiled gtest binaries, so these ~120 pure-Python tests currently run on no PR. Runs in seconds with no getdeps/docker.Differential Revision: D106542800