Mermaid lazy render when tab becomes visible#12281
Conversation
Lazy-render Mermaid diagrams when they enter the viewport so hidden tab panels do not produce incomplete SVG markers. Fixes facebook#8357. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @yoshibase! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Fixes #8357
Fix
Defer Mermaid rendering until the diagram container is visible (IntersectionObserver). Hidden tab panels no longer render incomplete SVG arrow markers.
Also sanitizes React
useId()output for Mermaid marker IDs.Test plan
Submit
Test plan