Skip to content

Mermaid lazy render when tab becomes visible#12281

Open
yoshibase wants to merge 1 commit into
facebook:mainfrom
yoshibase:fix/issue-8357-mermaid-tabs
Open

Mermaid lazy render when tab becomes visible#12281
yoshibase wants to merge 1 commit into
facebook:mainfrom
yoshibase:fix/issue-8357-mermaid-tabs

Conversation

@yoshibase

Copy link
Copy Markdown

Summary

Fixes #8357

Fix

Defer Mermaid rendering until the diagram container is visible (IntersectionObserver). Hidden tab panels no longer render incomplete SVG arrow markers.

Also sanitizes React useId() output for Mermaid marker IDs.

Test plan

  • Manual: dogfooding page with Mermaid in non-lazy tabs
  • Verify arrows render in second tab after switching

Submit

make submit CONTRIB=contrib-facebook-docusaurus/pr-8357-mermaid-tabs

Test plan

  • Local tests pass (see README in staging folder)

Lazy-render Mermaid diagrams when they enter the viewport so hidden tab
panels do not produce incomplete SVG markers. Fixes facebook#8357.

Co-authored-by: Cursor <cursoragent@cursor.com>
@meta-cla

meta-cla Bot commented Jul 13, 2026

Copy link
Copy Markdown

Hi @yoshibase!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Jul 13, 2026
@meta-cla

meta-cla Bot commented Jul 13, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mermaid in tabs. The arrows are not displayed in the second tab

1 participant