Skip to content

fix(js/ts): make Exception.ToString() return the message instead of "Exception" #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
klofberg wants to merge 1 commit into from
+13 −0
Closed

fix(js/ts): make Exception.ToString() return the message instead of "Exception" #4633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/fable-library-ts/Util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ export class Exception {
constructor(msg?: string) {
this.message = msg ?? "";
}

toString() {
return this.message;
}
}

export function isException(x: any) {
Expand Down
9 changes: 9 additions & 0 deletions tests/Js/Main/TypeTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,6 +1393,15 @@ let tests =
| ex -> (false, "unknown", 0.)
|> equal (true, "Code: 5", 5.5)

testCase "Exception ToString contains the message" <| fun () -> // See #4197
let msg =
try
failwith "test message"
""
with ex -> ex.ToString()
// .NET returns "System.Exception: test message", Fable returns just the message
msg.Contains("test message") |> equal true

testCase "reraise works" <| fun () ->
try
try
Expand Down
Loading