fix(res.format): ignore inherited default handler#7333
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
Contributor
|
I have the same question as in #7329 (comment) - why do you think that inherited properties should be ignored? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
res.format()invoke thedefaulthandler only when it is an own property of the formatter object.The regression test proves inherited default callbacks are ignored and the normal 406 path is preserved.
Validation:
npx mocha --require test/support/env --check-leaks test/res.format.jsnpm run lintgit diff --checkAI-assisted: Codex helped prepare this focused change; I reviewed the diff and ran the validation above before submitting.