Skip to content

Feature/722 nox session check#845

Open
ArBridgeman wants to merge 13 commits into
mainfrom
feature/722_nox_session_check
Open

Feature/722 nox session check#845
ArBridgeman wants to merge 13 commits into
mainfrom
feature/722_nox_session_check

Conversation

@ArBridgeman
Copy link
Copy Markdown
Collaborator

@ArBridgeman ArBridgeman commented May 22, 2026

closes #722
closes #642
closes #698
closes #690 (last child task)

Checklist

Note: If any of the items in the checklist are not relevant to your PR, just check the box.

For any Pull Request

Is the following correct:

  • the title of the Pull Request?
  • the title of the corresponding issue?
  • there are no other open Pull Requests for the same update/change?
  • that the issue which this Pull Request fixes ("Fixes...") is mentioned?

When Changes Were Made

Did you:

  • update the changelog?
  • update the cookiecutter-template?
  • update the implementation?
  • check coverage and add tests: unit tests and, if relevant, integration tests?
  • update the User Guide & other documentation?
  • resolve any failing CI criteria (incl. Sonar quality gate)?

When Preparing a Release

Have you:

  • thought about version number (major, minor, patch)?
  • checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

@ArBridgeman ArBridgeman force-pushed the feature/722_nox_session_check branch from 464f88e to cb2f05d Compare May 22, 2026 07:31
@ArBridgeman ArBridgeman force-pushed the feature/722_nox_session_check branch from 20dde53 to 806232b Compare May 22, 2026 09:07
@ArBridgeman ArBridgeman temporarily deployed to manual-approval May 22, 2026 09:07 — with GitHub Actions Inactive
Comment thread doc/changes/unreleased.md

## Summary

In this minor release, the nox session `workflow:check` was added and is now used in the `checks.yml`.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a project is not ready for this, they can remove the job with the .workflow-patcher.yml.

By adding a comment at the top of workflows maintained by the PTB, we make it clearer what is maintained vs not by us. Additionally, by adding when it was last updated, it gives the projects using the PTB a direct idea of when this was last touched before checking the git blame. [The PTB currently lacks a mechanism to say when a workflow was removed or not, but this comment could give an important hint. It also encourages user to NOT modify the .yml files but let the PTB maintain them.]

poetry run -- nox -s workflow:check --help

Use ``workflow:generate`` to create or update workflows and ``workflow:check`` to
compare the generated workflows against the files in ``.github/workflows``.
Copy link
Copy Markdown
Collaborator

@tkilias tkilias May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compare the generated workflows against the files in .github/workflows

This I don't understand, I thought the generated workflows would be in .github/workflows

maybe: compare the workflows that would be generated against ...

Copy link
Copy Markdown
Collaborator Author

@ArBridgeman ArBridgeman May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we compare the string content of the generated workflows to the existing files. Yeah, that could be better worded 😅 I updated the text so hopefully it's a bit clearer 😊

@ArBridgeman ArBridgeman deployed to manual-approval May 22, 2026 09:31 — with GitHub Actions Active
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants