feat(nodes): support description on node import#205
Merged
Conversation
Allow users to set an optional description when importing a self-managed node, in both the interactive flow and the manual import-ssh command. - interactive: prompt 'Description (optional):' just before confirmation; empty input is normalized to None - manual: new --description/-d flag on 'nodes import-ssh' - thread description through the request, params, service and SDK gateway - add description to BaseNode domain model and map it from SDK node responses; render it (as N/A when empty) in the node detail view - test that the description is forwarded to the gateway parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
descriptionfor self-managed node imports, in both theinteractive flow and the manual
import-sshcommand. The backend SDK(
exalsius_api_client) already accepts and returns the field; this wires itthrough the CLI.
Write (import):
exls nodes import: newDescription (optional):prompt justbefore the confirmation table; empty input is normalized to
None.exls nodes import-ssh: new--description/-dflag.Read (display):
descriptionto theBaseNodedomain model and mapped it from SDKnode responses.
exls nodes get) asN/Awhen empty;the list view is unchanged.