feat: max tx cost limit for redistribution game#5473
Conversation
# Conflicts: # cmd/bee/cmd/cmd.go # cmd/bee/cmd/start.go # pkg/node/node.go # pkg/storageincentives/redistribution/redistribution.go # pkg/transaction/mock/transaction.go # pkg/transaction/transaction.go
sbackend123
changed the title
# Conflicts: # pkg/postage/postagecontract/contract.go # pkg/postage/postagecontract/mock/contract.go # pkg/transaction/export_test.go # pkg/transaction/send_tx_with_retry.go # pkg/transaction/send_tx_with_retry_test.go
# Conflicts: # pkg/storageincentives/redistribution/redistribution.go # pkg/transaction/send_tx_with_retry.go # pkg/transaction/send_tx_with_retry_test.go
sbackend123
requested review from
akrem-chabchoub,
gacevicljubisa and
martinconic
| github.com/ethersphere/batch-archive v0.0.7 | ||
| github.com/ethersphere/go-price-oracle-abi v0.6.9 | ||
| github.com/ethersphere/go-storage-incentives-abi v0.9.4 | ||
| github.com/ethersphere/go-storage-incentives-abi v0.9.3-rc4 |
There was a problem hiding this comment.
this is intentional and will be updated before the merge?
There was a problem hiding this comment.
Only for testing on lighttestnet, will be removed before merge
| @@ -272,14 +321,18 @@ func (t *transactionService) retry(ctx context.Context, txRetryKey string, reque | |||
| t.recordRetryComplete(attempt, terminateTxErr) | |||
There was a problem hiding this comment.
is attempt, or attempt+1 like in line 311 ?
There was a problem hiding this comment.
Both To and Value and will cause a panic if nil, right?
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if request.GasFeeCap != nil { |
There was a problem hiding this comment.
This block (and the TxRequest.GasFeeCap field at line 88) is only reachable via the legacy Send path, but I don't see any caller that sets request.GasFeeCap — the redistribution changes here route through SendWithRetry/prepareTransactionForTier, which doesn't use prepareTransaction. Is this OK ?
There was a problem hiding this comment.
redundant code, removed
2 participants
Checklist
Description
Extends transactions with retry with per-call overrides and adds redistribution-game behaviour on top of existing settings.
Transaction layer
WithRetryDelay — override retry delay for one SendWithRetry call.
WithIgnoreMaxPrice — bypass maxTxPrice when a predicate allows it (predicate gets proposed max_fee_per_gas in wei).
Redistribution game
Retry delay: commit / reveal / claim use min(transaction-retry-delay, 35s) so more attempts fit in a phase without changing the global delay for other txs.
Gas: no GasPrice from context; fees via SendWithRetry. MinEstimatedGasLimit lowered from 500k to 250k.
Only claim may bypass maxTxPrice. In the last 10 blocks of the round, if expected reward > spent for fees, the cap is ignored for that attempt.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
A long retry delay can leave the user unable to resend the transaction before the redistribution game phase ends, which means losing the right to participate in that round. For that reason, the delay is shortened for commit, reveal, and claim transactions.
A claim transaction is also roughly 1.5× more expensive than commit and reveal. With a user-configured max tx cost, funds may already be spent on commit and reveal while claim never goes through because of the limit — leaving the user at a net loss. To avoid that, the node is allowed to ignore the configured limit.
Related Issue (Optional)
#5142
Screenshots (if appropriate):
AI Disclosure