ci: publish version from package.json (drop dirty-tree auto-bump)#135
Merged
Conversation
The previous \`pnpm version patch\` step ran \`pnpm i\` first, which under pnpm 11 dirties pnpm-workspace.yaml (the build-script approval wizard re-emits its prompt every install). \`pnpm version\` then aborts with \`ERR_PNPM_UNCLEAN_WORKING_TREE\` and the publish never runs — that's how 4.0.3 failed to ship after PR #131 merged. Switch to a simpler model: bump the version manually in the PR that needs to ship, then publish whatever version is in package.json on merge to main. Tag the commit only if no \`vX.Y.Z\` tag exists yet, and use \`pnpm publish --no-git-checks\` so transient working-tree state from pnpm itself doesn't block the publish.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the broken `pnpm version patch` auto-bump in `npmpublish.yml` with a simpler tag-and-publish-from-package.json flow.
Why
The previous Bump-version step ran `pnpm i` and then `pnpm version patch`. Under pnpm 11, `pnpm i` dirties `pnpm-workspace.yaml` on every invocation (the build-script approval wizard re-emits its prompt), so `pnpm version` then aborts with:
```
[ERR_PNPM_UNCLEAN_WORKING_TREE] Working tree is not clean. Commit or stash your changes.
```
That's how 4.0.3 failed to publish after #131 merged — the test job ran fine, publish-npm bailed on the dirty tree, npm still has 4.0.2.
New flow
Practical effect: contributors bump the version in the PR that needs to ship (we already did this for 4.0.3 in #131), and merging publishes it.
Test plan
Refs the dead 25965886065 publish run.