Support for custom geometries, as used for APS XBPMs#39
Open
anjohnson wants to merge 2 commits intoepics-modules:masterfrom
Open
Support for custom geometries, as used for APS XBPMs#39anjohnson wants to merge 2 commits intoepics-modules:masterfrom
anjohnson wants to merge 2 commits intoepics-modules:masterfrom
Conversation
Add documentation for the Custom geometry feature that allows user-defined weights for computing sum and difference values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
John Runchey worked in the APS Controls group during the APS Upgrade development and added the code here that supports custom geometries. His changes to the R9-4 release have been used for the Xray BPMs (xbpm) IOCs, and he submitted a PR #20 at the time to try to upstream them, but it was never merged. After he left he apparently cleaned up his GitHub account and deleted his fork, which automatically closed the PR.
The first commit in this PR includes his original code, rebased against the latest R9-6 release of quadEM.
The second commit was documentation developed by Claude Code that describes the changes. I have no objection to any changes needed to fix its wording.
I have compiled this, but not tested it. We are currently upgrading the xbpm IOCs to use R9-6 with this addition though, so any breakage should be discovered very soon.