test: deflake RateLimitGlobalMergeTest/shared_no_client_selectors#9427
test: deflake RateLimitGlobalMergeTest/shared_no_client_selectors#9427mmmommm wants to merge 1 commit into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| var sent int | ||
| require.Eventually(t, func() bool { | ||
| cReq, cRes, err := suite.RoundTripper.CaptureRoundTrip(expectOkReq) | ||
| sent++ |
There was a problem hiding this comment.
The root cause was that the test hard-coded the exact request at which a 429 is expected (send N, then assert the next is 429).
The fix send requests until a 429 is actually observed instead of pinning the count. I also added per-request logging so a timeout stays diagnosable now that we no longer check an exact count.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9427 +/- ##
==========================================
+ Coverage 75.41% 75.45% +0.04%
==========================================
Files 252 252
Lines 41660 41660
==========================================
+ Hits 31416 31435 +19
+ Misses 8115 8098 -17
+ Partials 2129 2127 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Kise Ryota <kiseryota.contact@gmail.com>
34a8402 to
8eb766e
Compare
What this PR does / why we need it:
fix the flaky ratelimit e2e test.
ran the e2e test 50 times in the local kind cluster and all passed.
Which issue(s) this PR fixes:
Fixes #8113
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.