Skip to content

feat: envoy extension policy listenerset attach#9425

Open
kkk777-7 wants to merge 3 commits into
envoyproxy:mainfrom
kkk777-7:feat-eep-ls-attach
Open

feat: envoy extension policy listenerset attach#9425
kkk777-7 wants to merge 3 commits into
envoyproxy:mainfrom
kkk777-7:feat-eep-ls-attach

Conversation

@kkk777-7

@kkk777-7 kkk777-7 commented Jul 6, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

follow-up #9270

Support policy attachment for ListenerSet.

This PR includes:

  • Policy attachment to ListenerSet and ListenerSet sections
  • Route policy attachment when a route has a ListenerSet parent

Which issue(s) this PR fixes:

Fixes #8092

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7 kkk777-7 requested a review from a team as a code owner July 6, 2026 15:23
@netlify

netlify Bot commented Jul 6, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit edc5df9
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a4bcf54587f2700087eec72
😎 Deploy Preview https://deploy-preview-9425--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7 kkk777-7 added this to the v1.9.0-rc.1 Release milestone Jul 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58c9a0d6c2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread api/v1alpha1/envoyextensionypolicy_types.go
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.15596% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.37%. Comparing base (98c1be7) to head (edc5df9).

Files with missing lines Patch % Lines
internal/gatewayapi/envoyextensionpolicy.go 85.26% 18 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9425      +/-   ##
==========================================
+ Coverage   75.34%   75.37%   +0.02%     
==========================================
  Files         252      252              
  Lines       41477    41612     +135     
==========================================
+ Hits        31252    31365     +113     
- Misses       8113     8128      +15     
- Partials     2112     2119       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7

kkk777-7 commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: edc5df9311

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@zirain

zirain commented Jul 7, 2026

Copy link
Copy Markdown
Member

one naive question: the EEP should located in the same namespace with ListenerSet, is that right?

@zhaohuabing

Copy link
Copy Markdown
Member

one naive question: the EEP should located in the same namespace with ListenerSet, is that right?

@zirain cross-namespace policy attachment has already been supported in #8676.

@zirain

zirain commented Jul 7, 2026

Copy link
Copy Markdown
Member

one naive question: the EEP should located in the same namespace with ListenerSet, is that right?

@zirain cross-namespace policy attachment has already been supported in #8676.

cc @guydc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ListenerSet as TargetRefs for xPolicies

3 participants