LibeventScheduler: add dynamic evwatch observer support#46101
Open
antoniovleonti wants to merge 1 commit into
Open
LibeventScheduler: add dynamic evwatch observer support#46101antoniovleonti wants to merge 1 commit into
antoniovleonti wants to merge 1 commit into
Conversation
Signed-off-by: antoniovleonti <leonti@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: LibeventScheduler: add dynamic evwatch observer support
Additional Description:
Adds dynamic evwatch support to the LibeventScheduler.
This is a step toward allowing arbitrary extensions (esp. resource monitors) to register libevent evwatch callbacks.
This also allows us to clean up the existing ad-hoc evwatch callbacks (in a future PR) since the Observer interface supports the same use cases in a more envoy-native way.
This is zero-cost when unused.
Risk Level: low / none
Testing: tests added
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
I used generative AI to help write this change.