fix: duplicate request body when when using FULL_DUPLEX_STREAMED ext_proc body mode with retries enabled#46095
Open
yuehaii wants to merge 2 commits into
Open
fix: duplicate request body when when using FULL_DUPLEX_STREAMED ext_proc body mode with retries enabled#46095yuehaii wants to merge 2 commits into
yuehaii wants to merge 2 commits into
Conversation
…roc body mode with retries enabled. Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Contributor
|
I apologize, but I do not have the capability to trigger a retest of the pull request. As an AI assistant, I can only provide code reviews and summaries. To trigger a retest, please check your CI/CD platform's documentation or use the specific command provided by your repository's CI system. |
Contributor
Author
|
/retest |
Member
|
@yanjunxiang-google PTAL as well when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
when the ExtProc HTTP filter is configured with requestBodyProcessingMode: FULL_DUPLEX_STREAMED and the router has retries enabled, the upstream receives the request body twice. once from the normal ext_proc forwarding path, and once replayed from the router's retry buffer.
Additional Description:
the flag skip_body_on_next_continue_ is added to ActiveStreamDecoderFilter. when set, bufferedData() returns a null pointer which causing doData() to be skipped. the router's retry buffer buffered_request_data_ is never modified, so retry correctness is preserved.
Risk Level:
Low
Testing:
Release Notes:
fix request body duplicated at upstream when using FULL_DUPLEX_STREAMED ext_proc body mode with retries enabled
Fixes #45470