access_loggers: use configured formatters for OpenTelemetry custom_tags#46066
Open
davidvo-lyft wants to merge 1 commit into
Open
access_loggers: use configured formatters for OpenTelemetry custom_tags#46066davidvo-lyft wants to merge 1 commit into
davidvo-lyft wants to merge 1 commit into
Conversation
The OpenTelemetry access loggers parse configured formatters into a command-parser vector for the body and attributes formatters, but getCustomTags() dropped it, so a custom tag whose value used a formatter extension (e.g. FILE_CONTENT) failed with "Not supported field in StreamInfo" while the same command worked in body/attributes. Thread the command parsers through to createCustomTag(). Applies to both the gRPC and HTTP OpenTelemetry loggers. Fixes envoyproxy#45453 Signed-off-by: David Vo <davidvo@lyft.com>
davidvo-lyft
temporarily deployed
to
external-contributors
GitHub Actions
Inactive
|
Hi @davidvo-lyft, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenTelemetry access loggers parse configured
formattersinto a command-parser vector for the body and attributes formatters, butgetCustomTags()dropped it. So a custom tag whose value used a formatter extension (e.g.FILE_CONTENT) failed with "Not supported field in StreamInfo", even though the same command worked inbody/attributes. This threads the command parsers through tocreateCustomTag(). Applies to both the gRPC and HTTP OpenTelemetry loggers.Risk Level: Low
Testing: new unit test (red->green) plus the existing otel access-log unit and config tests pass.
Docs Changes: n/a
Release Notes: changelog added
Fixes #45453