Skip to content

Entropy : Zero 2 Vortigaunts in EZ1#343

Open
1upD wants to merge 17 commits into
entropy-zero:ez1/devfrom
1upD:ez1/feature/ez2-vortigaunts
Open

Entropy : Zero 2 Vortigaunts in EZ1#343
1upD wants to merge 17 commits into
entropy-zero:ez1/devfrom
1upD:ez1/feature/ez2-vortigaunts

Conversation

@1upD

@1upD 1upD commented Jul 13, 2025

Copy link
Copy Markdown

This PR is to cherry-pick content relating to EZ2 vorts into EZ1.

This will be opened in DRAFT status until it is ready for review.

@1upD 1upD force-pushed the ez1/feature/ez2-vortigaunts branch from 153d43a to 69f8aa0 Compare July 14, 2025 03:21
@1upD 1upD marked this pull request as ready for review July 31, 2025 04:00
@1upD 1upD requested a review from Blixibon June 16, 2026 05:05

@Blixibon Blixibon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this PR contains a lot of code from Mapbase that's nested within #ifdef MAPBASE blocks, as well as a few bits that still have #ifdef EZ2. Doesn't this branch not implement those preprocessors?

@1upD

1upD commented Jun 16, 2026

Copy link
Copy Markdown
Author

I noticed this PR contains a lot of code from Mapbase that's nested within #ifdef MAPBASE blocks, as well as a few bits that still have #ifdef EZ2. Doesn't this branch not implement those preprocessors?

That's a good shout. From what I remember, the MAPBASE preprocessor is defined as we had some Mapbase code in the codebase at the time (I still need to double check this) and EZ is defined, but EZ2 is not. Some of things in #ifdef EZ2 preprocessor blocks are meant to be reserved only for EZ2, but I think I should check all of them to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants