I2C4 AF Pin Mapping Updates#701
Open
stephenhensley wants to merge 2 commits into
Open
Conversation
6a3ee66 to
3bdb835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a project that uses the H7 with a few new pins, and they don't map to the existing fixed-AF mapping based on peripheral selection.
IIRC there may also have been an existing issue with using I2C4 with some of the pins available on the Seed.
This update adds a pin map to the i2c peripheral containing the Alternate functions for all supported pins (and the ones I'm using.
Things to do before merging:
I observed about 1kB increase in binary size after this update. The new mapping is set up to be constexpr, but the typical usage patterns involve runtime
Configstructs. So in most existing uses it won't qualify for finding them at compile time.