Skip to content

Stabilize ruby:3.4/sinatra-1.4 matrix by hardening SSL connection spec isolation#1638

Merged
estolfo merged 2 commits into
mainfrom
copilot/fix-github-actions-job
Jun 19, 2026
Merged

Stabilize ruby:3.4/sinatra-1.4 matrix by hardening SSL connection spec isolation#1638
estolfo merged 2 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The matrix / test (ruby:3.4, sinatra-1.4) job was failing due to a cascade from verify_server_cert specs in connection_spec: an unexpected TLS transport error caused one example to fail while WebMock remained disabled, which then broke many unrelated specs.

  • Root-cause containment in verify_server_cert specs

    • Wrapped WebMock.disable! sections with begin ... ensure ... end so WebMock is always re-enabled, even when the example raises.
    • Prevents global test state leakage and downstream false failures.
  • Expectation scope tightened for verify_server_cert: false

    • Updated the negative logger assertion to target certificate-verification failures only (instead of broad SSL_connect matching), aligning the check with what the example intends to prove.
  • Illustrative change

    WebMock.disable!
    begin
      subject.write('')
      subject.flush
    ensure
      WebMock.enable!
    end

Copilot AI changed the title [WIP] Fix failing GitHub Actions job matrix / test (ruby:3.4, sinatra-1.4) Stabilize ruby:3.4/sinatra-1.4 matrix by hardening SSL connection spec isolation Jun 19, 2026
Copilot AI requested a review from estolfo June 19, 2026 08:23
@estolfo estolfo marked this pull request as ready for review June 19, 2026 08:34
@estolfo estolfo requested a review from hegerchr June 19, 2026 08:34

@hegerchr hegerchr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estolfo estolfo merged commit 3585cd8 into main Jun 19, 2026
51 checks passed
@estolfo estolfo deleted the copilot/fix-github-actions-job branch June 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants