Skip to content

Fix failing CI job "matrix / test (ruby:2.4, rails-4.2)" by correcting i18n version pin#1634

Merged
estolfo merged 3 commits into
mainfrom
copilot/fix-github-actions-matrix-test
Jun 18, 2026
Merged

Fix failing CI job "matrix / test (ruby:2.4, rails-4.2)" by correcting i18n version pin#1634
estolfo merged 3 commits into
mainfrom
copilot/fix-github-actions-matrix-test

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The CI job matrix / test (ruby:2.4, rails-4.2) was failing due to a bundle update dependency resolution error introduced by a recent change that pinned i18n to version 1.14.8 for all Rails versions on Ruby < 3.2.

Root Cause

Commit d7f24f0 added gem 'i18n', '1.14.8' to fix a runtime error with i18n 1.15.0 (which uses Fiber[] requiring Ruby 3.2+ but incorrectly declares required_ruby_version >= 3.1). However, the condition was too broad: Rails 4.2 requires i18n ~> 0.7 (< 1.0), which is directly incompatible with the 1.14.8 pin, causing Bundler to fail with unresolvable dependency conflicts.

Fix

Narrowed the i18n pin condition in the Gemfile to only apply when the Rails version is >= 5.2, since Rails 5.2+ supports i18n >= 0.7, < 2 (and therefore accepts 1.14.8), while Rails 4.x requires i18n ~> 0.7 (< 1.0).

# Before
if framework == 'rails' && RUBY_VERSION < '3.2' && !defined?(JRUBY_VERSION)
  gem 'i18n', '1.14.8'
end

# After
if framework == 'rails' && RUBY_VERSION < '3.2' && !defined?(JRUBY_VERSION) && version >= '5.2'
  gem 'i18n', '1.14.8'
end

@estolfo estolfo marked this pull request as ready for review June 18, 2026 14:53
Copilot AI changed the title [WIP] Fix failing GitHub Actions job matrix/test for Ruby 3.4 and Rails 6.1 Stabilize Ruby 3.4 / Rails 6.1 SSL transport spec expectations Jun 18, 2026
Copilot AI requested a review from estolfo June 18, 2026 14:54

@hegerchr hegerchr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI changed the title Stabilize Ruby 3.4 / Rails 6.1 SSL transport spec expectations Fix failing CI job "matrix / test (ruby:2.4, rails-4.2)" by correcting i18n version pin Jun 18, 2026
Copilot AI requested a review from estolfo June 18, 2026 15:35
@estolfo estolfo merged commit 56528cc into main Jun 18, 2026
1 check passed
@estolfo estolfo deleted the copilot/fix-github-actions-matrix-test branch June 18, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants