Fix failing CI job "matrix / test (ruby:2.4, rails-4.2)" by correcting i18n version pin#1634
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job matrix/test for Ruby 3.4 and Rails 6.1
Stabilize Ruby 3.4 / Rails 6.1 SSL transport spec expectations
Jun 18, 2026
estolfo
approved these changes
Jun 18, 2026
Copilot
AI
changed the title
Stabilize Ruby 3.4 / Rails 6.1 SSL transport spec expectations
Fix failing CI job "matrix / test (ruby:2.4, rails-4.2)" by correcting i18n version pin
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI job
matrix / test (ruby:2.4, rails-4.2)was failing due to abundle updatedependency resolution error introduced by a recent change that pinnedi18nto version1.14.8for all Rails versions on Ruby < 3.2.Root Cause
Commit
d7f24f0addedgem 'i18n', '1.14.8'to fix a runtime error withi18n 1.15.0(which usesFiber[]requiring Ruby 3.2+ but incorrectly declaresrequired_ruby_version >= 3.1). However, the condition was too broad: Rails 4.2 requiresi18n ~> 0.7(< 1.0), which is directly incompatible with the 1.14.8 pin, causing Bundler to fail with unresolvable dependency conflicts.Fix
Narrowed the
i18npin condition in theGemfileto only apply when the Rails version is>= 5.2, since Rails 5.2+ supportsi18n >= 0.7, < 2(and therefore accepts 1.14.8), while Rails 4.x requiresi18n ~> 0.7(< 1.0).