Remove "prioritize_full_name_in_ux"#1
Open
mtancoigne wants to merge 1051 commits into
Open
Conversation
mtancoigne
force-pushed
the
manu/remove-prioritize_full_name_in_ux
branch
from
f82804c to
986f8f9
Compare
github-actions
Bot
added
discourse-reactions
discourse-assign
and removed
migrations-tooling
i18n
labels
mtancoigne
force-pushed
the
manu/remove-prioritize_full_name_in_ux
branch
from
986f8f9 to
a87e1c4
Compare
github-actions
Bot
added
i18n
chat
checklist
discourse-details
discourse-lazy-videos
discourse-local-dates
discourse-narrative-bot
discourse-presence
discourse-apple-auth
discourse-login-with-amazon
discourse-lti
discourse-microsoft-auth
discourse-oauth2-basic
discourse-openid-connect
discourse-zendesk-plugin
discourse-patreon
discourse-graphviz
discourse-rss-polling
discourse-math
discourse-chat-integration
discourse-data-explorer
discourse-post-voting
labels
The AI plugin has a custom feature settings editor that uses FormKit to render site settings. When commit e8d63c9 (discourse#38552) moved the `@type` attribute onto `form.Field`, it added type mappings for `bool`, `integer`, `enum`, and `list` but missed `group_list` (and `category_list` in the fallback branch). Since `group_list` didn't match any condition, it fell through to `"input"`, causing the field to render as a plain text input displaying raw pipe-separated IDs like "1|4" instead of a group selector. Before: <img width="701" height="1284" alt="Screenshot 2026-04-10 at 2 29 21 pm" src="https://github.com/user-attachments/assets/f4d286a3-7c60-4bc7-bf02-b1c38d0b2010" /> After: <img width="739" height="1300" alt="Screenshot 2026-04-10 at 2 18 28 pm" src="https://github.com/user-attachments/assets/d6bd4438-3b7e-4378-a6f8-f72ffb1626f5" />
Regardless of date, if there is a banner topic, we should translate as soon as possible, it is shown to users on the homepage.
… same (discourse#39202) When the site setting for navigation menu is set to header dropdown, we prevent the AI bot button from navigating users back to their last forum page (this is the behavior when the sidebar is enabled). The behavior of the bot icon here always navigates you to the AI conversation interface, even when you're already in it: <img width="370" height="108" alt="image" src="https://github.com/user-attachments/assets/43cf0e85-b97f-45da-b7c1-7e61e21d7192" /> I can't see any reason for this divergence in behavior, and the lack of a "back to forum" button feels missed in header dropdown mode. This removes the navigation mode check so the button always behaves the same. So now when in AI conversations, you can get back to where you left off in the forum: <img width="378" height="106" alt="image" src="https://github.com/user-attachments/assets/be48b54d-5b30-4501-8b06-642ddcdf0f84" />
When tagging is disabled we put the category input on the same line as the topic title in the composer. Currently when a category is selected this can overflow. This fixes it by forcing the category input to shrink. Before: <img width="350" alt="image" src="https://github.com/user-attachments/assets/24d7af6a-6001-4990-a333-8e803a726ae6" /> After: <img width="350" alt="image" src="https://github.com/user-attachments/assets/2f044a18-44c5-4c6a-b124-a60902e2cc40" />
Just need to swap in the i18n version of this text
…n_ux" in simple lines
mtancoigne
force-pushed
the
manu/remove-prioritize_full_name_in_ux
branch
from
a87e1c4 to
29bafda
Compare
mtancoigne
pushed a commit
that referenced
this pull request
Apr 13, 2026
…iscourse#38835) This is a follow-up to f369c4d (discourse#38790) which fixed bulk select not toggling off after using Bulk Actions > Dismiss on the /new route. There are two ways to dismiss new topics while in bulk select mode: 1. The "Bulk Actions" dropdown > "Dismiss" button in the sticky header 2. The "Dismiss New" button at the bottom of the topic list The previous fix only addressed path #1. Path #2 (the "Dismiss New" button) was still leaving bulk select enabled after dismissing. Additionally, these two paths were using entirely different code: - The button used `Topic.resetNew()` (correct endpoint for new topics) - The dropdown used `bulkSelectHelper.dismissRead()` which calls `Topic.bulkOperation()` with `change_notification_level` — an endpoint designed for unread topics, not new ones This commit unifies both paths to go through the controller's `resetNew()` → `callResetNew()` → `Topic.resetNew()` chain by adding an `onResetNew` callback on `BulkSelectHelper` (same pattern as the existing `onBulkSelectToggle`). Both paths now correctly use `Topic.resetNew()` and toggle off bulk select when done. System specs now cover both dismiss paths independently. Ref - t/180286
github-actions
Bot
removed
discourse-reactions
discourse-assign
discourse-details
discourse-lazy-videos
discourse-local-dates
discourse-narrative-bot
discourse-presence
discourse-apple-auth
discourse-login-with-amazon
discourse-lti
discourse-microsoft-auth
discourse-oauth2-basic
discourse-openid-connect
discourse-zendesk-plugin
discourse-patreon
discourse-graphviz
discourse-rss-polling
discourse-math
labels
|
This pull request has been automatically marked as stale because it has been open for 60 days with no activity. To keep it open, remove the stale tag, push code, or add a comment. Otherwise, it will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.