Skip to content

Demo cleanup#163

Open
sproctor wants to merge 14 commits into
ehsannarmani:masterfrom
sproctor:demo_cleanup
Open

Demo cleanup#163
sproctor wants to merge 14 commits into
ehsannarmani:masterfrom
sproctor:demo_cleanup

Conversation

@sproctor

Copy link
Copy Markdown
Contributor

This moves the theme into common code and makes dark mode togglable and demonstrates how to use use theme colors for text. It's missing settings the theme color a bunch of samples.

@ehsannarmani ehsannarmani left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sproctor , thanks for your PR.

  1. Please resolve conflicts.
  2. We have so many unnecessary changes and unrelated changes to cleanup in this PR, like adding multi-theme mode, updating publish workflow, changing package names and some descriptions and ..., please review your changes and update them with keeping commit history clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants