Wip tmp tracability improvements#572
Draft
MaximilianSoerenPollak wants to merge 10 commits into
Draft
Conversation
Saving metrics before deleting process reqs
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
Contributor
Author
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Commenting some things.
| extensions = [ | ||
| "score_sphinx_bundle", | ||
| ] | ||
| matplotlib.rcParamsDefault["savefig.bbox"] = "tight" |
Contributor
Author
There was a problem hiding this comment.
Probably should have this in the extension so it's set for all things that import docs-as-code
| @@ -18,7 +18,7 @@ | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
Ignore this file, has not yet been changed / updated to new architecture
| @@ -31,9 +31,6 @@ | |||
| ProhibitedWordCheck as ProhibitedWordCheck, | |||
Contributor
Author
There was a problem hiding this comment.
Was moved to it's own extension
| @@ -0,0 +1,218 @@ | |||
| # ******************************************************************************* | |||
Contributor
Author
There was a problem hiding this comment.
Tests commented out (to test the metrics stuff).
Will be redone once arch is finished
Comment on lines
+52
to
+59
| app.add_config_value( | ||
| "score_metamodel_requirement_types", | ||
| "", | ||
| rebuild="env", | ||
| description=( | ||
| "Comma-separated list of need types treated as requirements for " | ||
| "traceability metrics. If empty, requirement types are autodiscovered " | ||
| "from needs_types tags (requirement, requirement_excl_process)." |
Contributor
Author
There was a problem hiding this comment.
Should be moved to other function. calculate_need_metrics
|
|
||
| def generic_pie_linked_items( | ||
| needs: list[NeedItem], results: list[int], **kwargs: str | int | float | ||
| needs: list[NeedItem], results: list[int], **kwargs: dict[str, str | int | float] |
Contributor
Author
There was a problem hiding this comment.
Kwargs typhint should be 'Any' maybe?
Comment on lines
+170
to
+175
| def get_metrics_from_generated_json( | ||
| needs: list[NeedItem], results: list[int], **kwargs: str | int | float | ||
| ) -> None: | ||
| metrics_json_path = str(kwargs.get("arg1", "_build/metrics.json")) | ||
| # TODO: Read the Metrics.json and give back the data | ||
| results |
Contributor
Author
There was a problem hiding this comment.
Delete
| _get_key_values(results, [str(value) for value in kwargs.values()]) | ||
|
|
||
|
|
||
| # def set_default_include_external(include_external: bool) -> None: |
Contributor
Author
There was a problem hiding this comment.
Re-Read commented out functions, see what 'general' functions you are missing from there if any.
| @@ -0,0 +1,208 @@ | |||
| # ******************************************************************************* | |||
Contributor
Author
There was a problem hiding this comment.
Many of this has been copied from the old '_write_metrics' function.
But simplified.
| @@ -219,9 +219,10 @@ def read_test_xml_file(file: Path) -> tuple[list[DataOfTestCase], list[str], lis | |||
| properties_element = testcase.find("properties") | |||
Contributor
Author
There was a problem hiding this comment.
Should this be in a seperate PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a waffle as thanks 🧇