Replace CSSSWTTestCase inheritance with a JUnit 5 extension#4162
Open
vogella wants to merge 1 commit into
Open
Replace CSSSWTTestCase inheritance with a JUnit 5 extension#4162vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
The css.swt widget tests inherited Display and engine handling plus a protected mutable display field from a common base class, which tied every test to that superclass. A CssSwtEngine extension registered via RegisterExtension now owns engine creation, the widget helpers and shell cleanup; tests access the display and engine through accessors and are free to extend other bases.
vogella
added a commit
to vogella/eclipse.platform.ui
that referenced
this pull request
Jul 4, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The widget tests in org.eclipse.e4.ui.tests.css.swt all had to extend CSSSWTTestCase to get a Display, engine creation and shell cleanup, and they shared its protected mutable display field. This replaces the base class with a CssSwtEngine extension registered via @RegisterExtension: the extension owns the engine and widget helpers, exposes the display and engine through accessors, and disposes open shells after each test. The tests keep their exact behavior (the full suite passes with the same totals as before) and are now free to extend other bases.
Part of #3980.