Android: Fix chats menu not dismissing when NTP is shown#8963
Open
karlenDimla wants to merge 1 commit into
Open
Android: Fix chats menu not dismissing when NTP is shown#8963karlenDimla wants to merge 1 commit into
karlenDimla wants to merge 1 commit into
Conversation
Track the chats popup shown from the chats icon and dismiss it in onStop() so the popup window is closed before the contextual sheet goes away and the NTP takes over. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1215828353176637?focus=true
Tech Design URL (if applicable):
Description
What: Dismiss the chats popup menu in onStop(), clearing the reference via its dismiss listener.
Why: The popup is a standalone window not tied to the sheet's lifecycle. When the NTP is shown, the popup is left open. The simplest solution is to hide the icon when the tab loses focus.
Steps to test this PR
Note
Low Risk
Small UI lifecycle change in one fragment; no auth, data, or business-logic impact.
Overview
Fixes the contextual Duck AI chats menu staying on screen when the user navigates away (e.g. opening the NTP) while the popup is open.
DuckChatContextualFragmentnow keeps a reference to the activePopupMenu, clears it on dismiss, and callsdismiss()inonStop()so the overlay is torn down when the fragment is no longer visible.Reviewed by Cursor Bugbot for commit 697e087. Bugbot is set up for automated code reviews on this repo. Configure here.