Skip to content

de-emphasize input in Duck.ai onboarding demo#8962

Open
LukasPaczos wants to merge 2 commits into
developfrom
feature/lpaczos/custom-ai-onboarding/de-emphasize-input-in-duckai-demo
Open

de-emphasize input in Duck.ai onboarding demo#8962
LukasPaczos wants to merge 2 commits into
developfrom
feature/lpaczos/custom-ai-onboarding/de-emphasize-input-in-duckai-demo

Conversation

@LukasPaczos

@LukasPaczos LukasPaczos commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1215914551889857?focus=true
Tech Design URL (if applicable):

Description

De-emphasize input in Duck.ai onboarding demo.

Steps to test this PR

  • Apply this diff
diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/CustomAiOnboardingStore.kt b/app/src/main/java/com/duckduckgo/app/onboarding/CustomAiOnboardingStore.kt
index 9da0ed066d..d75613086b 100644
--- a/app/src/main/java/com/duckduckgo/app/onboarding/CustomAiOnboardingStore.kt
+++ b/app/src/main/java/com/duckduckgo/app/onboarding/CustomAiOnboardingStore.kt
@@ -101,6 +101,7 @@ class CustomAiOnboardingStoreImpl @Inject constructor(
     }
 
     override suspend fun resolve() = resolveMutex.withLock {
+        return@withLock true
         withContext(dispatcherProvider.io()) {
             // Ensure the install referrer (and therefore the processing function) has resolved before reading.
             withTimeoutOrNull(MAX_REFERRER_WAIT_TIME_MS) { referrerStateListener.get().waitForReferrerCode() }
@@ -118,6 +119,7 @@ class CustomAiOnboardingStoreImpl @Inject constructor(
     }
 
     override suspend fun isEnabled(): Boolean = resolveMutex.withLock {
+        return@withLock true
         withContext(dispatcherProvider.io()) {
             preferences.getBoolean(PREFS_KEY_ENABLED, false)
         }
  • Clean install the app
  • Go through the onboarding until reaching the Duck.ai demo
  • Verify the elevation is removed and a small stroke is applied
  • Finish onboarding
  • Open Duck.ai
  • Verify the full-size shadow is applied

UI changes

Before After
Screenshot_20260622_163731 Screenshot_20260622_180707

Note

Low Risk
Localized UI styling in an existing lock/unlock path; no auth, data, or submission logic changes.

Overview
Extends setInteractionLocked on the native Duck.ai input widget so onboarding (and any other interaction lock) de-emphasizes the omnibar input, not only dimming controls and blocking touches.

When locked, the widget now finds the wrapping inputModeWidgetCard on widgetRoot, stores its current elevation (top vs bottom omnibar use different values), sets elevation to 0, and applies a 1dp stroke tinted with the background attribute so the field reads flatter and less prominent. Unlock restores the saved elevation and clears the stroke.

Adds getColorFromAttr / toPx helpers for that stroke styling.

Reviewed by Cursor Bugbot for commit 2bacecd. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5116267. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants