Skip to content

Duck.ai onboarding translations#8953

Open
lmac012 wants to merge 60 commits into
developfrom
feature/lukasz/duck-ai-onboarding-translations
Open

Duck.ai onboarding translations#8953
lmac012 wants to merge 60 commits into
developfrom
feature/lukasz/duck-ai-onboarding-translations

Conversation

@lmac012

@lmac012 lmac012 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1205648422731273/task/1215849619469941
Tech Design URL (if applicable):

Description

Adds translations for the Duck.ai onboarding CTAs across supported locales, makes the related onboarding strings translatable, and includes brand-design copy tweaks plus ad-blocking string translations.

Steps to test this PR

N/A – translations only.

UI changes

Before After
No UI changes No UI changes

Note

Low Risk
String-resource and layout reference changes only; no logic or security impact beyond possible copy/formatting quirks (e.g. LT newline).

Overview
This PR localizes onboarding copy that previously lived only in English donottranslate.xml by moving Duck.ai, custom AI flow, and input-mode demo strings into the main strings.xml and adding locale-specific translations across supported languages.

Brand-design onboarding now uses dedicated string keys (preOnboardingDaxDialog1ButtonBrandDesign, onboardingPrivacyProDaxDialogFreeTrialOkButtonBrandDesign) in the brand-design layout and DaxSubscriptionBrandDesignUpdateBubbleCta instead of the generic button labels.

Locales gain translated strings for Duck.ai Fire Button / end CTAs, the custom AI pre-onboarding path (welcome, comparison chart, default-browser prompt, in-context end), and input demo hints where applicable (e.g. pt, sk). Duck Chat adds Bulgarian end-CTA strings. Lithuanian ad-blocking consent text drops a paragraph break between two sentences.

Reviewed by Cursor Bugbot for commit 1bd6637. Bugbot is set up for automated code reviews on this repo. Configure here.

lmac012 and others added 30 commits June 22, 2026 13:18
Translate strings-ad-blocking to values-nb
Translate strings-ad-blocking to values-sl
Translate strings-ad-blocking to values-cs
Translate strings-ad-blocking to values-fi
Translate strings-ad-blocking to values-lt
Translate strings-ad-blocking to values-hu
Translate strings-ad-blocking to values-hr
Translate strings-ad-blocking to values-bg
Translate strings-ad-blocking to values-tr
Translate strings-ad-blocking to values-de
Translate strings-ad-blocking to values-it
Translate strings-ad-blocking to values-sv
Translate strings-ad-blocking to values-ro
Translate strings-ad-blocking to values-pl
Translate strings-ad-blocking to values-ru
Translate strings-ad-blocking to values-da
Translate strings-ad-blocking to values-el
Translate strings-ad-blocking to values-nl
Translate strings-ad-blocking to values-lv
Translate strings-ad-blocking to values-pt
Translate strings-ad-blocking to values-sk
Translate strings-ad-blocking to values-et
Translate strings-ad-blocking to values-fr
Translate strings to values-sv
Translate strings to values-fr
Translate strings-duckchat to values-sv
Translate strings-duckchat to values-hr
Translate strings to values-hu
Translate strings-duckchat to values-hu
Translate strings to values-cs
Translate strings-duckchat to values-it
Comment thread ad-blocking/ad-blocking-impl/src/main/res/values-el/strings-ad-blocking.xml Outdated
smartling and others added 6 commits June 22, 2026 08:49
Translate strings-ad-blocking to values-nb
Translate strings-ad-blocking to values-sl
Translate strings-ad-blocking to values-cs
Translate strings-ad-blocking to values-fi
Translate strings-ad-blocking to values-lt
Translate strings-ad-blocking to values-hu
Translate strings-ad-blocking to values-hr
Translate strings-ad-blocking to values-bg
Translate strings-ad-blocking to values-tr
Translate strings-ad-blocking to values-de
Translate strings-ad-blocking to values-it
Translate strings-ad-blocking to values-sv
Translate strings-ad-blocking to values-ro
Translate strings-ad-blocking to values-pl
Translate strings-ad-blocking to values-ru
Translate strings-ad-blocking to values-da
Translate strings-ad-blocking to values-el
Translate strings-ad-blocking to values-nl
Translate strings-ad-blocking to values-lv
Translate strings-ad-blocking to values-pt
Translate strings-ad-blocking to values-sk
Translate strings-ad-blocking to values-et
Translate strings-ad-blocking to values-fr

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7e054ae. Configure here.

<string name="ad_blocking_settings_title">„YouTube“ reklamų blokavimas</string>
<string name="ad_blocking_settings_toggle_title">Blokuoti „YouTube“ reklamas</string>
<string name="ad_blocking_settings_description_with_consent">„DuckDuckGo“ blokuoja vaizdo įrašų reklamas platformoje „YouTube“, todėl galite žiūrėti vaizdo įrašus be trukdžių.\n\nKai įjungta, „DuckDuckGo“ anonimiškai aptiks skelbimų blokavimo trukdžius arba „YouTube“ klaidas, kad pagerintų patirtį visiems. „DuckDuckGo“ niekada nemato, kokius vaizdo įrašus žiūrite, ar bet kokios asmenį identifikuojančios informacijos. <annotation type="learn_more_link">Sužinokite daugiau</annotation></string>
<string name="ad_blocking_settings_description_with_consent">„DuckDuckGo“ blokuoja vaizdo įrašų reklamas platformoje „YouTube“, todėl galite žiūrėti vaizdo įrašus be trukdžių.Kai įjungta, „DuckDuckGo“ anonimiškai aptiks skelbimų blokavimo trukdžius arba „YouTube“ klaidas, kad pagerintų patirtį visiems. „DuckDuckGo“ niekada nemato, kokius vaizdo įrašus žiūrite, ar bet kokios asmenį identifikuojančios informacijos. <annotation type="learn_more_link">Sužinokite daugiau</annotation></string>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing paragraph break LT

Low Severity

The Lithuanian ad_blocking_settings_description_with_consent string omits the \n\n paragraph break between the opening sentence and the consent paragraph. English and every other locale updated in this diff keep that break, so LT users see one run-on block (e.g. be trukdžių.Kai įjungta) instead of two paragraphs in ad blocking settings.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7e054ae. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants