Don't tag tasks from hotfix as included in LGC#8928
Open
CrisBarreiro wants to merge 2 commits into
Open
Conversation
daxmobile
reviewed
Jun 18, 2026
Collaborator
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:40: Double quote to prevent globbing and word splitting [shellcheck]
daxmobile
reviewed
Jun 18, 2026
Collaborator
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:30: Double quote to prevent globbing and word splitting [shellcheck]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1211760946270935/task/1215767779355614?focus=true
Tech Design URL (if applicable):
Description
Steps to test this PR
Feature 1
scripts/release/collect-lgc-asana-tasks.py --end-commit 4e0f10ba52c40837d90aa26f1d9f5739e7cf4284 --android-repo-path . --trigger-phrase "Task/Issue URL:" --start-tag 5.283.1and check 12 tasks are returned, not 13Note
Low Risk
Changes are limited to release automation scripts and tests; they only affect which Asana tasks are tagged for LGC, not app runtime behavior.
Overview
Fixes LGC Asana task collection so tasks already shipped on a hotfix release are not reported as new for LGC when the hotfix tag is not on the same history as the LGC end commit.
collect-lgc-asana-tasks.pyadds optional--start-tag(instead of always using the latest public release). Whenstart_tagis not an ancestor ofend_commit, the script loads task IDs from commits between the previous public release tag andstart_tag, and drops those IDs from the JSON output. On normal releases where the start tag is an ancestor, that extra filter is skipped.asana_release_utils.pyaddsis_ancestorviagit merge-base --is-ancestor. Tests cover the filter paths,--start-tag, andis_ancestor.Reviewed by Cursor Bugbot for commit 3cf24fa. Bugbot is set up for automated code reviews on this repo. Configure here.