Skip to content

Don't tag tasks from hotfix as included in LGC#8928

Open
CrisBarreiro wants to merge 2 commits into
developfrom
fix/cris/do-not-tag-hotfixed-tasks-in-lgc
Open

Don't tag tasks from hotfix as included in LGC#8928
CrisBarreiro wants to merge 2 commits into
developfrom
fix/cris/do-not-tag-hotfixed-tasks-in-lgc

Conversation

@CrisBarreiro

@CrisBarreiro CrisBarreiro commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211760946270935/task/1215767779355614?focus=true
Tech Design URL (if applicable):

Description

  • Filter out tasks from hotfix before manipulating them
  • Before tagging tasks, add them to the release board (waiting for release)
    • If the task is already there, this is a no-op, so no notifications will be triggered

Steps to test this PR

Feature 1

  • Manually run scripts/release/collect-lgc-asana-tasks.py --end-commit 4e0f10ba52c40837d90aa26f1d9f5739e7cf4284 --android-repo-path . --trigger-phrase "Task/Issue URL:" --start-tag 5.283.1 and check 12 tasks are returned, not 13
  • Optionally, run the tests

Note

Low Risk
Changes are limited to release automation scripts and tests; they only affect which Asana tasks are tagged for LGC, not app runtime behavior.

Overview
Fixes LGC Asana task collection so tasks already shipped on a hotfix release are not reported as new for LGC when the hotfix tag is not on the same history as the LGC end commit.

collect-lgc-asana-tasks.py adds optional --start-tag (instead of always using the latest public release). When start_tag is not an ancestor of end_commit, the script loads task IDs from commits between the previous public release tag and start_tag, and drops those IDs from the JSON output. On normal releases where the start tag is an ancestor, that extra filter is skipped.

asana_release_utils.py adds is_ancestor via git merge-base --is-ancestor. Tests cover the filter paths, --start-tag, and is_ancestor.

Reviewed by Cursor Bugbot for commit 3cf24fa. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:40: Double quote to prevent globbing and word splitting [shellcheck]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:30: Double quote to prevent globbing and word splitting [shellcheck]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants