Skip to content

Subscriptions: Improve Back button experience#8923

Open
nalcalag wants to merge 3 commits into
developfrom
feature/noelia/improve_subscriptions_back_action_experience
Open

Subscriptions: Improve Back button experience#8923
nalcalag wants to merge 3 commits into
developfrom
feature/noelia/improve_subscriptions_back_action_experience

Conversation

@nalcalag

@nalcalag nalcalag commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1204912272578138/task/1215248979171838?focus=true

Description

Improve back behaviour in subscription screen

Steps to test this PR

Pre steps

No purchase

  • Instal from branch
  • Go to Settings > Onboarding Dev Settings
  • Toggle off DAX_INTRO_PRIVACY_PRO
  • Go back to browser where subscription dialog will appear
  • Tap on 'Learn More'
  • Exit subscription screen without finishing a purchase
  • Verify it gets back to the browser and no settings screen

purchase success

  • Go to Settings > Onboarding Dev Settings
  • Toggle off DAX_INTRO_PRIVACY_PRO
  • Go back to browser where subscription dialog will appear
  • Tap on 'Learn More'
  • Purchase a test subscription
  • Verify it now gets back to the settings screen

restore success

  • Remove account from device
  • Tap on 'I have a Subscription'
  • Tap on 'Add via Google Play Account'
  • Verify it now gets back to the settings screen

No UI changes


Note

Low Risk
Navigation-only changes in the subscriptions UI with no billing, auth, or data-handling logic modified; main risk is incorrect back-stack behavior in edge entry points.

Overview
Subscription launch no longer pre-stacks Settings under the subscription web view. launchSubscription starts only SubscriptionsWebViewActivity, so dismissing without completing a purchase returns the user to the prior screen (e.g. browser) instead of Settings.

Completion paths route to Settings when appropriate. backToSettings is renamed to finishToSettings: for non-activate flows it starts Settings with CLEAR_TOP / SINGLE_TOP then finishes; activate URL still sets RESULT_OK only. Purchase success, recovered, and JS BackToSettings commands use this helper instead of a bare finish().

Hardware/toolbar back after a completed purchase flow (success, waiting, or recovered) calls finishToSettings() when the WebView cannot go back, aligning back with post-purchase expectations. Unit tests for launchSubscription now expect a single startIntent (web view only).

Reviewed by Cursor Bugbot for commit 99f6629. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review June 18, 2026 14:32

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3e4a267. Configure here.

@nalcalag nalcalag force-pushed the feature/noelia/improve_subscriptions_back_action_experience branch from 3e4a267 to 99f6629 Compare June 22, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants