Subscriptions: Improve Back button experience#8923
Open
nalcalag wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3e4a267. Configure here.
3e4a267 to
99f6629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1204912272578138/task/1215248979171838?focus=true
Description
Improve back behaviour in subscription screen
Steps to test this PR
Pre steps
No purchase
purchase success
restore success
No UI changes
Note
Low Risk
Navigation-only changes in the subscriptions UI with no billing, auth, or data-handling logic modified; main risk is incorrect back-stack behavior in edge entry points.
Overview
Subscription launch no longer pre-stacks Settings under the subscription web view.
launchSubscriptionstarts onlySubscriptionsWebViewActivity, so dismissing without completing a purchase returns the user to the prior screen (e.g. browser) instead of Settings.Completion paths route to Settings when appropriate.
backToSettingsis renamed tofinishToSettings: for non-activate flows it starts Settings withCLEAR_TOP/SINGLE_TOPthen finishes; activate URL still setsRESULT_OKonly. Purchase success, recovered, and JS BackToSettings commands use this helper instead of a barefinish().Hardware/toolbar back after a completed purchase flow (success, waiting, or recovered) calls
finishToSettings()when the WebView cannot go back, aligning back with post-purchase expectations. Unit tests forlaunchSubscriptionnow expect a singlestartIntent(web view only).Reviewed by Cursor Bugbot for commit 99f6629. Bugbot is set up for automated code reviews on this repo. Configure here.