Skip to content

Create DaxTopAppBar and DaxSearchTopAppBar in Compose#8904

Open
GerardPaligot wants to merge 1 commit into
feature/gerard/compose-icon-buttonfrom
feature/gerard/compose-topappbars
Open

Create DaxTopAppBar and DaxSearchTopAppBar in Compose#8904
GerardPaligot wants to merge 1 commit into
feature/gerard/compose-icon-buttonfrom
feature/gerard/compose-topappbars

Conversation

@GerardPaligot

@GerardPaligot GerardPaligot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1215496415658080/task/1215793451599391

Description

Create DaxTopAppBar and DaxSearchTopAppBar for page header navigation component.

Steps to test this PR

  • Install the branch on your device
  • Open the design system screen and go to the layout tab
  • Check top app bar and search bar are working well and are similar to XML view

UI changes

image image

image image


Note

Low Risk
New design-system UI and lint-only enforcement; no production screen migrations in this diff, so runtime impact is limited to the internal preview until features adopt the composables.

Overview
Adds Compose design-system top app bars: DaxTopAppBar (title, optional shadow, navigation via Back/Close, action slots) and DaxSearchTopAppBar, which layers an animated search field over the bar with placeholder, clear, IME search, and exit-search handling.

The internal design-system preview drops the XML MaterialToolbar sample in favor of a themed ComposeView that demos both variants (including toggling search active state), and Layouts now lists TOP_APP_BAR alongside cards.

Lint registers NoMaterial3TopAppBarUsage to error on Material3 TopAppBar / CenterAlignedTopAppBar / etc. outside design-system modules, with unit tests. Non-translatable content descriptions were added for bar and search controls.

Reviewed by Cursor Bugbot for commit 2117fd8. Bugbot is set up for automated code reviews on this repo. Configure here.

GerardPaligot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 62f3e4b. Configure here.

@GerardPaligot GerardPaligot force-pushed the feature/gerard/compose-topappbars branch from 62f3e4b to 0eaf678 Compare June 17, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants