Create DaxTopAppBar and DaxSearchTopAppBar in Compose#8904
Open
GerardPaligot wants to merge 1 commit into
Open
Create DaxTopAppBar and DaxSearchTopAppBar in Compose#8904GerardPaligot wants to merge 1 commit into
GerardPaligot wants to merge 1 commit into
Conversation
This was referenced Jun 17, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 62f3e4b. Configure here.
62f3e4b to
0eaf678
Compare
0eaf678 to
2117fd8
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1215496415658080/task/1215793451599391
Description
Create DaxTopAppBar and DaxSearchTopAppBar for page header navigation component.
Steps to test this PR
UI changes
Note
Low Risk
New design-system UI and lint-only enforcement; no production screen migrations in this diff, so runtime impact is limited to the internal preview until features adopt the composables.
Overview
Adds Compose design-system top app bars:
DaxTopAppBar(title, optional shadow, navigation viaBack/Close, action slots) andDaxSearchTopAppBar, which layers an animated search field over the bar with placeholder, clear, IME search, and exit-search handling.The internal design-system preview drops the XML
MaterialToolbarsample in favor of a themedComposeViewthat demos both variants (including toggling search active state), and Layouts now listsTOP_APP_BARalongside cards.Lint registers
NoMaterial3TopAppBarUsageto error on Material3TopAppBar/CenterAlignedTopAppBar/ etc. outside design-system modules, with unit tests. Non-translatable content descriptions were added for bar and search controls.Reviewed by Cursor Bugbot for commit 2117fd8. Bugbot is set up for automated code reviews on this repo. Configure here.