Skip to content

Fire Mode: Prepare fire dialog#8902

Open
0nko wants to merge 2 commits into
feature/ondrej/fire-mode-disable-syncfrom
feature/ondrej/fire-mode-dialog
Open

Fire Mode: Prepare fire dialog#8902
0nko wants to merge 2 commits into
feature/ondrej/fire-mode-disable-syncfrom
feature/ondrej/fire-mode-dialog

Conversation

@0nko

@0nko 0nko commented Jun 16, 2026

Copy link
Copy Markdown
Member

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1215767831573342?focus=true

Description

This PR updates the copy and prepares the single tab fire dialog for Fire mode.

Steps to test this PR

Prerequisite: an internal build with Fire mode enabled (the fireMode / fireTabs remote feature flag on).

Fire mode — new dialog copy

  • Switch to Fire mode and open a regular website tab (e.g. example.com).
  • Tap the Fire button. Verify the dialog title reads "Delete Fire Tabs and their data?" with Delete This Tab and Delete All buttons. Dismiss without clearing.

Regular mode — copy unchanged (regression)

  • In Regular mode, open a website tab and tap the Fire button. Verify the title still reads "Delete tabs and site data?" with the same buttons.

Duck.ai chat tab — copy unchanged

  • Open a Duck.ai chat tab (either mode) and tap the Fire button. Verify the title still reads "Delete this chat?" with a single Delete Chat button.

Note

Medium Risk
Changes user-facing copy and branches the Fire button delete-all path away from real data clearing in Fire mode (stub until follow-up), so testers should confirm users are not misled that data was wiped.

Overview
Prepares the single-tab fire dialog for Fire mode by wiring in BrowserMode and changing copy/behavior before Fire-tab-specific clearing lands in a follow-up.

In Fire mode, the dialog title becomes "Delete Fire Tabs and their data?" (singleTabFireDialogTitleFireMode) for normal website tabs (and when Duck.ai chats are selected in manual clear options). Duck.ai chat tabs still use the existing Duck.ai title. Regular mode titles are unchanged.

Delete All is split by mode: regular mode keeps the existing manual fire clear path (pixels, wide events, clearDataUsingManualFireOptions). In Fire mode, Delete All only runs the clear-started/optional animation flow and does not call manual fire clear or fire the same telemetry yet; actual Fire-tab clearing is left as TODOs (same for Delete This Tab in Fire mode, which still uses the regular clear path for now).

Unit tests cover Fire-mode titles, regression for regular mode, and that Fire-mode Delete All skips clearDataUsingManualFireOptions while still emitting ClearingComplete.

Reviewed by Cursor Bugbot for commit 44bd718. Bugbot is set up for automated code reviews on this repo. Configure here.

0nko commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko force-pushed the feature/ondrej/fire-mode-disable-sync branch from b39544d to 95870fc Compare June 18, 2026 08:11
@0nko 0nko force-pushed the feature/ondrej/fire-mode-dialog branch from 189a306 to 65ada87 Compare June 18, 2026 08:11
@0nko 0nko mentioned this pull request Jun 18, 2026
22 tasks

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 65ada87. Configure here.

@0nko 0nko requested a review from CDRussell June 18, 2026 20:26
@0nko 0nko force-pushed the feature/ondrej/fire-mode-dialog branch from 65ada87 to 8053a49 Compare June 22, 2026 19:31
@0nko 0nko force-pushed the feature/ondrej/fire-mode-disable-sync branch from 95870fc to 4abf6e5 Compare June 22, 2026 19:31
0nko and others added 2 commits June 22, 2026 23:31
Co-authored-by: Ondrej Ruttkay <0nko@users.noreply.github.com>
@0nko 0nko force-pushed the feature/ondrej/fire-mode-disable-sync branch from 706e37c to 69eba25 Compare June 22, 2026 21:31
@0nko 0nko force-pushed the feature/ondrej/fire-mode-dialog branch from 84c7c36 to 44bd718 Compare June 22, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants