Fire Mode: Prepare fire dialog#8902
Open
0nko wants to merge 2 commits into
Open
Conversation
This was referenced Jun 16, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2026
b39544d to
95870fc
Compare
189a306 to
65ada87
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 65ada87. Configure here.
CDRussell
approved these changes
Jun 22, 2026
65ada87 to
8053a49
Compare
95870fc to
4abf6e5
Compare
Co-authored-by: Ondrej Ruttkay <0nko@users.noreply.github.com>
706e37c to
69eba25
Compare
84c7c36 to
44bd718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1215767831573342?focus=true
Description
This PR updates the copy and prepares the single tab fire dialog for Fire mode.
Steps to test this PR
Prerequisite: an internal build with Fire mode enabled (the
fireMode/fireTabsremote feature flag on).Fire mode — new dialog copy
Regular mode — copy unchanged (regression)
Duck.ai chat tab — copy unchanged
Note
Medium Risk
Changes user-facing copy and branches the Fire button delete-all path away from real data clearing in Fire mode (stub until follow-up), so testers should confirm users are not misled that data was wiped.
Overview
Prepares the single-tab fire dialog for Fire mode by wiring in
BrowserModeand changing copy/behavior before Fire-tab-specific clearing lands in a follow-up.In Fire mode, the dialog title becomes "Delete Fire Tabs and their data?" (
singleTabFireDialogTitleFireMode) for normal website tabs (and when Duck.ai chats are selected in manual clear options). Duck.ai chat tabs still use the existing Duck.ai title. Regular mode titles are unchanged.Delete All is split by mode: regular mode keeps the existing manual fire clear path (pixels, wide events,
clearDataUsingManualFireOptions). In Fire mode, Delete All only runs the clear-started/optional animation flow and does not call manual fire clear or fire the same telemetry yet; actual Fire-tab clearing is left as TODOs (same for Delete This Tab in Fire mode, which still uses the regular clear path for now).Unit tests cover Fire-mode titles, regression for regular mode, and that Fire-mode Delete All skips
clearDataUsingManualFireOptionswhile still emittingClearingComplete.Reviewed by Cursor Bugbot for commit 44bd718. Bugbot is set up for automated code reviews on this repo. Configure here.