Fix duplicated-word typos in code comments and log message#8860
Open
Amir-yazdanmanesh wants to merge 1 commit into
Open
Fix duplicated-word typos in code comments and log message#8860Amir-yazdanmanesh wants to merge 1 commit into
Amir-yazdanmanesh wants to merge 1 commit into
Conversation
Remove accidental duplicated words ('is is', 'the the', 'and and',
'of of') in KDoc/comments across NetP, GPC, sync, and the browser
navigation bar, plus one duplicated 'of' in a sync error log message.
2 tasks
malmstein
pushed a commit
that referenced
this pull request
Jun 23, 2026
…bmitted pixels (#8966) Task/Issue URL: https://app.asana.com/1/137249556945/project/1213746476312668/task/1215891186389639 ### Description Live pixel validation reported that `m_aichat_unified_input_prompt_submitted_count` and `m_aichat_unified_input_prompt_submitted_daily` were failing with `/reasoning_effort must be equal to one of the allowed values`. Root cause: the `reasoning_effort` parameter on these two pixels is populated by `NativeInputModeWidgetViewModel.fireSubmissionPixels()` → `getResolvedReasoningEffort()`, which returns `ReasoningEffort.rawValue` — one of `none`, `minimal`, `low`, `medium`, `high` (the same resolved effort value that is sent to the backend via `sendPrompt`). However, the pixel definition declared the enum as `["fast", "reasoning", "extended_reasoning"]`, which are the `ReasoningMode` raw values. Those mode values are correctly used by the separate `m_aichat_unified_input_reasoning_effort_selected` pixel's `effort_level` parameter (`ReasoningMode.toEffortParam()`), but not by the prompt-submitted pixels. This change aligns the `reasoning_effort` enum on both prompt-submitted pixel definitions with the actual wire values (`ReasoningEffort` raw values). No code behaviour changes — only the definition in `PixelDefinitions/pixels/definitions/duck_chat.json5` is updated. The unrelated `reasoning_effort_selected` pixel's `effort_level` enum is intentionally left untouched. 🤖 Android Maintenance Worker ### Steps to test this PR _Lint / formatting_ - [ ] `cd PixelDefinitions && npm run lint` (prettier — passes locally) - [ ] `cd PixelDefinitions && npm run validate-defs-without-formatting` (pixel-schema validation) Note: only a PixelDefinitions JSON5 file changed (no Kotlin/Android source), so `./gradlew spotlessCheck` / `lint_check` have nothing applicable to check for this change. `npm run lint` (prettier) passed locally; `npm run validate-defs-without-formatting` could not complete in the sandbox because it fetches the live target app version over the network (`ERROR in product.json target version: fetch failed`), which the CI sandbox firewall blocks — this is unrelated to the change and will run on CI. ### UI changes | Before | After | | ------ | ----- | | No UI changes | No UI changes | > [!NOTE] > <details> > <summary><b>🔒 Integrity filter blocked 3 items</b></summary> > > The following items were blocked because they don't meet the GitHub integrity level. > > - [#8942](#8942) `list_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#8860](#8860) `list_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#8844](#8844) `list_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [Android Maintenance Worker](https://github.com/duckduckgo/Android/actions/runs/28006631632/agentic_workflow) · [◷](https://github.com/search?q=repo%3Aduckduckgo%2FAndroid+%22gh-aw-workflow-id%3A+android-maintenance-worker%22&type=pullrequests) <!-- gh-aw-agentic-workflow: Android Maintenance Worker, engine: claude, model: auto, id: 28006631632, workflow_id: android-maintenance-worker, run: https://github.com/duckduckgo/Android/actions/runs/28006631632 --> <!-- gh-aw-workflow-id: android-maintenance-worker --> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Schema-only change in PixelDefinitions with no Android runtime behavior changes; it restores validation for analytics events already emitted by the app. > > **Overview** > Fixes live pixel validation failures on **`m_aichat_unified_input_prompt_submitted_count`** and **`m_aichat_unified_input_prompt_submitted_daily`** by updating the **`reasoning_effort`** parameter schema in `duck_chat.json5`. > > The allowed values change from **`fast` / `reasoning` / `extended_reasoning`** (UI **`ReasoningMode`**) to **`none` / `minimal` / `low` / `medium` / `high`**, matching what the app already sends via **`getResolvedReasoningEffort()`** (`ReasoningEffort` raw values). The parameter description now says **resolved** reasoning effort. **`m_aichat_unified_input_reasoning_effort_selected`** and its **`effort_level`** enum are unchanged. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e704fae. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: #8859
Tech Design URL (if applicable):
Description
Fixes #8859.
Removes accidental duplicated words in code comments / KDoc and one error
log message. These are documentation-only, no-op cleanups with no behavior
change:
BrowserNavigationBarViewIntegration— "when the the fragment's view" → "when the fragment's view"AutoExcludeAppsRepository(3 KDoc blocks) — "apps that is is part of" → "apps that is part of"Gpc— "falseis is not" → "falseif not"SyncAccountRepository— "new ID and and public/private key-pair" → "new ID and public/private key-pair"SyncApiClient— error log "inform sync of of deleted duck ai chats" → "inform sync of deleted duck ai chats"No production code paths, public APIs, or string resources are affected.
Steps to test this PR
Typo fixes (no runtime behavior change)
./gradlew :sync-impl:testDebugUnitTest :network-protection-impl:testDebugUnitTest./gradlew spotlessCheckUI changes
Note
Low Risk
Comment and log-message edits only; no runtime, security, or API behavior is modified.
Overview
Fixes duplicated-word typos in KDoc, class comments, and one sync error log across browser navigation, VPN auto-exclude, GPC API, and sync modules. Examples include “the the”, “is is”, “and and”, and “of of” in documentation strings;
SyncApiClient’s Duck AI chat deletion failure log is corrected the same way.No executable logic, APIs, or user-facing strings change—documentation and logging text only.
Reviewed by Cursor Bugbot for commit 97f7eac. Bugbot is set up for automated code reviews on this repo. Configure here.