arm64: Add float/double cast optimisation tests#129517
Open
jonathandavies-arm wants to merge 2 commits into
Open
arm64: Add float/double cast optimisation tests#129517jonathandavies-arm wants to merge 2 commits into
jonathandavies-arm wants to merge 2 commits into
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
|
@jonathandavies-arm change lgtm Is the motivation for this #124081 ? Which gives us fp-typed masks now. Or is there a different motivating change? Worth putting in the pr description. |
Open
3 tasks
Contributor
Author
I was asked to implement the fp-typed masks but found that Alan had already done the work. I did think we should have better disassembly tests. |
Contributor
Author
|
Updated description. |
Change-Id: I03f182f358444c8eb2f7775a62454c38c881bed4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds targeted disassembly tests for the floating-point predicate codegen scenarios work done in #124081, including checks that unnecessary predicate→vector→predicate conversions are not emitted.