Skip to content

Fix GenerateMsiVersion task parameter names to match targets file #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcpopMSFT wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Open

Fix GenerateMsiVersion task parameter names to match targets file #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/core-sdk-tasks/GenerateMsiVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ namespace Microsoft.DotNet.Cli.Build
public class GenerateMsiVersion : Task
{
[Required]
public int CommitCount { get; set; }
public int BuildNumber { get; set; }

[Required]
public int VersionMajor { get; set; }
public int Major { get; set; }

[Required]
public int VersionMinor { get; set; }
public int Minor { get; set; }

[Required]
public int VersionPatch { get; set; }
public int Patch { get; set; }

[Output]
public string MsiVersion { get; set; }
Expand All @@ -27,10 +27,10 @@ public override bool Execute()
{
var buildVersion = new Version()
{
Major = VersionMajor,
Minor = VersionMinor,
Patch = VersionPatch,
CommitCount = CommitCount
Major = Major,
Minor = Minor,
Patch = Patch,
CommitCount = BuildNumber
};

MsiVersion = buildVersion.GenerateMsiVersion();
Expand Down
Loading